Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cloudfront): check size of the Cache Policy headers #13425

Merged
merged 5 commits into from
Mar 9, 2021

Conversation

robertd
Copy link
Contributor

@robertd robertd commented Mar 5, 2021

Similar to #13410


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Mar 5, 2021

@github-actions github-actions bot added the @aws-cdk/aws-cloudfront Related to Amazon CloudFront label Mar 5, 2021
@robertd robertd changed the title chore(cloudfront): check the size of the Cache Policy headers chore(cloudfront): check size of the Cache Policy headers Mar 5, 2021
@robertd robertd force-pushed the robertd/cloudfront-cache-policy branch from cbdc4d7 to 1182725 Compare March 5, 2021 22:44
@robertd
Copy link
Contributor Author

robertd commented Mar 9, 2021

@njlynch Would you mind reviewing this PR when time permits?

Copy link
Contributor

@njlynch njlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mergify
Copy link
Contributor

mergify bot commented Mar 9, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 8d6e009
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Mar 9, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit e08213f into aws:master Mar 9, 2021
njlynch added a commit that referenced this pull request Mar 31, 2021
Validation was added in #13425 to enforce a limit of the number of headers
allowed in the allow list for a Cache Policy; that limit is a soft limit and
should not be hard-enforced in code.

fixes #13903

This reverts commit e08213f.
mergify bot pushed a commit that referenced this pull request Apr 2, 2021
Validation was added in #13425 to enforce a limit of the number of headers
allowed in the allow list for a Cache Policy; that limit is a soft limit and
should not be hard-enforced in code.

fixes #13903

This reverts commit e08213f.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
…3904)

Validation was added in aws#13425 to enforce a limit of the number of headers
allowed in the allow list for a Cache Policy; that limit is a soft limit and
should not be hard-enforced in code.

fixes aws#13903

This reverts commit e08213f.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-cloudfront Related to Amazon CloudFront
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants