feat(events): EventBus.grantPutEventsTo method for granular grants
#13429
Conversation
|
|
DaWyz
force-pushed
the
DaWyz/event-bus-grant-putevents
branch
from
8709cb9
to
9c2712c
Compare
| * | ||
| * @param grantee The principal (no-op if undefined) | ||
| */ | ||
| grantPutEventsTo(grantee: iam.IGrantable): iam.Grant; |
There was a problem hiding this comment.
grantPutEvents is already taken by the static method. Should I drop the static method and rename this ? (That would be a breaking change..)
There was a problem hiding this comment.
Resolving as this a stable module and the contributing guide says no breaking changes on stable modules.
There was a problem hiding this comment.
Yap, that is unfortunate.
Can I ask you to, in this same commit, to @deprecate the current grantPutEvents and add a new one that's called grantAllPutEvents as well?
Then we are set up to rename this to grantPutEvents at some point in the future once we've removed deprecated APIs.
There was a problem hiding this comment.
Makes sense. It's done ! Ready for review
DaWyz
force-pushed
the
DaWyz/event-bus-grant-putevents
branch
from
9c2712c
to
6533ffa
Compare
| * | ||
| * @param grantee The principal (no-op if undefined) | ||
| */ | ||
| grantPutEventsTo(grantee: iam.IGrantable): iam.Grant; |
There was a problem hiding this comment.
Yap, that is unfortunate.
Can I ask you to, in this same commit, to @deprecate the current grantPutEvents and add a new one that's called grantAllPutEvents as well?
Then we are set up to rename this to grantPutEvents at some point in the future once we've removed deprecated APIs.
DaWyz
changed the title
rix0rrr
changed the title
EventBus.grantPutEventsTo method for granular grants
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Right now EventBus has a static method
grantPutEvents()which grants PutEvents to all EventBridge buses in the account.Adding a
grantPutEventsTo()method to the IEventBus interface that grants PutEvents to the specific event bus.We are also deprecating
grantPutEvents()in favor tograntAllPutEvents()which has the same behavior.Closes #11228.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license