Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(codebuild): allow setting queued timeout #13467

Merged
merged 13 commits into from
Mar 8, 2021

Conversation

ialford
Copy link
Contributor

@ialford ialford commented Mar 8, 2021

Closes #11364


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Mar 8, 2021

@github-actions github-actions bot added the @aws-cdk/aws-codebuild Related to AWS CodeBuild label Mar 8, 2021
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @ialford , thanks so much for the contribution!

A few documentation suggestions before we merge this puppy in!

packages/@aws-cdk/aws-codebuild/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-codebuild/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-codebuild/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-codebuild/README.md Outdated Show resolved Hide resolved
@mergify mergify bot dismissed skinny85’s stale review March 8, 2021 19:00

Pull request has been modified.

@ialford
Copy link
Contributor Author

ialford commented Mar 8, 2021

@skinny85 - I have incorporated your suggestions. Let me know if there's anything else!

Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ialford !

@mergify
Copy link
Contributor

mergify bot commented Mar 8, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 65a5e1f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Mar 8, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit e09250b into aws:master Mar 8, 2021
@ialford ialford deleted the feat-codebuild-queuetimeout branch March 8, 2021 21:07
cornerwings pushed a commit to cornerwings/aws-cdk that referenced this pull request Mar 8, 2021
Closes aws#11364

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This was referenced Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-codebuild Related to AWS CodeBuild
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[codebuild] support LogsConfig and QueuedTimeoutInMinutes in L2 construct
3 participants