Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(aws-cdk-lib): change namespaces/package names in line with RFC 6 #13494

Merged
merged 3 commits into from
Mar 10, 2021

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Mar 9, 2021

Changes:

  • .NET: Namespace changed from Amazon.CDK.Lib -> Amazon.CDK (so Stack has the same FQN, same namespace as in Monocdk)
  • Java: Package name changed from software.amazon.awscdk.lib -> software.amazon.awscdk.core (so Stack has the same FQN, same namespace as in Monocdk)
  • Java: Changed artifact ID to match what's written in RFC 6
  • Python: Changed dist name to match what's written in RFC 6
  • Python: Change namespace to aws_cdk instead of aws_cdk_lib for minimal interference. Still need to test whether it's okay to change this to aws_cdk.core (like for Java) so Stack will keep the same FQN. Monocdk does something different for Python.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Backported change from v2 branch: #13489.
@rix0rrr rix0rrr requested a review from nija-at March 9, 2021 15:01
@rix0rrr rix0rrr self-assigned this Mar 9, 2021
@gitpod-io
Copy link

gitpod-io bot commented Mar 9, 2021

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 9, 2021
@rix0rrr rix0rrr changed the title chore(python): change Python namespace to aws_cdk chore(aws-cdk-lib): change namespaces/package names in line with RFC 6 Mar 10, 2021
@github-actions github-actions bot added the aws-cdk-lib Related to the aws-cdk-lib package label Mar 10, 2021
@mergify
Copy link
Contributor

mergify bot commented Mar 10, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 909f040
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Mar 10, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws-cdk-lib Related to the aws-cdk-lib package contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants