Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): 1.94.1 #13625

Merged
merged 4 commits into from
Mar 16, 2021
Merged

chore(release): 1.94.1 #13625

merged 4 commits into from
Mar 16, 2021

Conversation

iliapolo
Copy link
Contributor

@iliapolo iliapolo commented Mar 16, 2021

See CHANGELOG


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

#13624)

This [PR](#13488) upgraded our Node runtimes from `10` to `14`. The problem is that Node14 isn't supported for lambda functions using inline code (i.e `ZipFile`). 

Change to Node12 specifically for the notification handler since it's the only one using `InlineLambda`. 

Fixes #13620

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@gitpod-io
Copy link

gitpod-io bot commented Mar 16, 2021

@iliapolo iliapolo added the pr/no-squash This PR should be merged instead of squash-merging it label Mar 16, 2021
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 16, 2021
@@ -11,7 +11,7 @@ const forTesting = process.env.BUMP_CANDIDATE || false;

async function main() {
if (releaseAs !== 'minor' && releaseAs !== 'patch') {
throw new error(`invalid bump type "${releaseAs}". only "minor" (the default) and "patch" are allowed. major version bumps require *slightly* more intention`);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Random bug I stumbled upon

@iliapolo iliapolo requested a review from a team March 16, 2021 22:55
@mergify
Copy link
Contributor

mergify bot commented Mar 16, 2021

Thank you for contributing! Your pull request will be automatically updated and merged without squashing (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 60d8f91 into release Mar 16, 2021
@mergify mergify bot deleted the patch/v1.94.1 branch March 16, 2021 23:25
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 3d65124
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. pr/no-squash This PR should be merged instead of squash-merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants