Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(codepipeline-actions): update CloudTrail example for addS3EventSelector #13728

Merged
merged 4 commits into from
Mar 22, 2021
Merged

docs(codepipeline-actions): update CloudTrail example for addS3EventSelector #13728

merged 4 commits into from
Mar 22, 2021

Conversation

niklaswallerstedt
Copy link
Contributor

Fixes #13684

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Mar 22, 2021 •
edited
Loading

@skinny85 skinny85 changed the title docs(aws-codepipeline-actions): update cloudtrail example for addS3EventSelector docs(codepipeline-actions): update CloudTrail example for addS3EventSelector Mar 22, 2021
skinny85
skinny85 approved these changes Mar 22, 2021
View reviewed changes
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @niklaswallerstedt!

@mergify
Copy link
Contributor

mergify bot commented Mar 22, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Mar 22, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Mar 22, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 3c38e86
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Mar 22, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit ffb0cc7 into aws:master Mar 22, 2021
@niklaswallerstedt niklaswallerstedt deleted the update-docs branch March 22, 2021 16:59
eladb pushed a commit that referenced this pull request Mar 24, 2021
@niklaswallerstedt
docs(codepipeline-actions): update CloudTrail example for addS3EventS…
e197392 
…elector (#13728)

Fixes #13684


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
@niklaswallerstedt @hollanddd
docs(codepipeline-actions): update CloudTrail example for addS3EventS…
a1b39cd 
…elector (aws#13728)

Fixes aws#13684


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skinny85 skinny85 skinny85 approved these changes

Assignees

@skinny85 skinny85

@NetaNir NetaNir

Labels
@aws-cdk/aws-cloudtrail Related to AWS CloudTrail @aws-cdk/aws-codepipeline-actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(aws-codepipeline-actions): Type 'string' is not assignable to type 'S3EventSelector'.
4 participants
@niklaswallerstedt @aws-cdk-automation @skinny85 @NetaNir