fix(cli): 'cdk synth' not able to fail if stacks have errors #14475
Conversation
|
|
| @@ -394,14 +394,15 @@ export class CdkToolkit { | |||
|
|
|||
| private async selectStacksForDiff(stackNames: string[], exclusively?: boolean) { | |||
There was a problem hiding this comment.
selectStacksForDiff ? Is that just a poorly chosen name?
It's a bit confusing in this context.
There was a problem hiding this comment.
The same stacks are selected for diff and synthesis. This method is reused in both contexts.
| @@ -394,14 +394,15 @@ export class CdkToolkit { | |||
|
|
|||
| private async selectStacksForDiff(stackNames: string[], exclusively?: boolean) { | |||
| const assembly = await this.assembly(); | |||
| const stacks = await assembly.selectStacks(stackNames, { | |||
|
|
|||
| const idsToValidate = process.env.STACKS_TO_VALIDATE ? process.env.STACKS_TO_VALIDATE.split(';') : stackNames; | |||
There was a problem hiding this comment.
Did we confirm that the method of using an environment variable is going to scale to large sizes? Or are we going to use wildcards?
There was a problem hiding this comment.
I've tried with values as long as 50K characters and it worked fine.
otaviomacedo
changed the title
rix0rrr
changed the title
rix0rrr
changed the title
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
The environment variable `STACKS_TO_VALIDATE` contains the stack hierarchical ids that should be validated after synthesis. By default (when the variable is undefined), it validates only the printed stacks, keeping backward compatibility. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
The environment variable `STACKS_TO_VALIDATE` contains the stack hierarchical ids that should be validated after synthesis. By default (when the variable is undefined), it validates only the printed stacks, keeping backward compatibility. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
The environment variable
STACKS_TO_VALIDATEcontains the stack hierarchical ids that should be validated after synthesis. By default (when the variable is undefined), it validates only the printed stacks, keeping backward compatibility.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license