chore(cli integ tests): delete bootstrap stacks last #14505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are running into conflicts where the toolkit stack canary is deleting bootstrap stacks before application stacks, which ends up with the `cfn-exec-role` being deleted before the application stack is deleted, causing errors.
|
|
eladb
approved these changes
May 3, 2021
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
rix0rrr
added a commit
that referenced
this pull request
May 3, 2021
This is a follow-up to #14505 which in retrospect wasn't complete. The list of stacks was ordered properly, but since all stacks were being deleted in parallel this didn't actually solve the race condition. Delete stacks in series instead.
mergify bot
pushed a commit
that referenced
this pull request
May 4, 2021
This is a follow-up to #14505 which in retrospect wasn't complete. The list of stacks was ordered properly, but since all stacks were being deleted in parallel this didn't actually solve the race condition. Delete stacks in series instead. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
john-tipper
pushed a commit
to john-tipper/aws-cdk
that referenced
this pull request
May 10, 2021
We are running into conflicts where the toolkit stack canary is deleting bootstrap stacks before application stacks, which ends up with the `cfn-exec-role` being deleted before the application stack is deleted, causing errors. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
john-tipper
pushed a commit
to john-tipper/aws-cdk
that referenced
this pull request
May 10, 2021
This is a follow-up to aws#14505 which in retrospect wasn't complete. The list of stacks was ordered properly, but since all stacks were being deleted in parallel this didn't actually solve the race condition. Delete stacks in series instead. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Aug 26, 2021
We are running into conflicts where the toolkit stack canary is deleting bootstrap stacks before application stacks, which ends up with the `cfn-exec-role` being deleted before the application stack is deleted, causing errors. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Aug 26, 2021
This is a follow-up to aws#14505 which in retrospect wasn't complete. The list of stacks was ordered properly, but since all stacks were being deleted in parallel this didn't actually solve the race condition. Delete stacks in series instead. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are running into conflicts where the toolkit stack canary
is deleting bootstrap stacks before application stacks, which ends
up with the
cfn-exec-rolebeing deleted before the application stackis deleted, causing errors.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license