-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(msk): IAM access control for clusters #14647
Conversation
a8075bd
to
796f99d
Compare
MSK now supports IAM access control for client authentication with a MSK cluster. https://aws.amazon.com/about-aws/whats-new/2021/05/introducing-iam-access-control-amazon-msk/
796f99d
to
e18a4e3
Compare
@curtiseppel Can I ask you to resolve the conflicts so the diff is up to date? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@curtiseppel PR looks good. But build is still failing. Happy to approve after the build passes.
Got mixed up in the previous merge commit
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
MSK now supports IAM access control for client authentication with a MSK cluster. https://aws.amazon.com/about-aws/whats-new/2021/05/introducing-iam-access-control-amazon-msk/ ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@gmuslia Looks like a bug here with the @curtiseppel Not sure how involved you are with CDK anymore but jfyi 😄 |
I think this should do it: #31743 cc/ @gmuslia @curtiseppel |
Pointed out [here](#14647 (comment)) and verified in the Console, both `SASL/SCRAM` and `IAM` can be enabled together. Closes #32779 It's a little confusing because [CloudFormation](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-msk-cluster-sasl.html) groups `Iam` and `Scram` together under `Sasl`, but the Console separates the two and allows both at the same time. I'd like to refactor this further but this change unblocks the issue where `SASL/SCRAM` and `IAM` cannot be enabled together. ![image](https://github.com/user-attachments/assets/60dd662e-4db9-4bbb-bcc0-67bd059f6870)
MSK now supports IAM access control for client authentication with a MSK
cluster.
https://aws.amazon.com/about-aws/whats-new/2021/05/introducing-iam-access-control-amazon-msk/
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license