Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(msk): IAM access control for clusters #14647

Merged
merged 4 commits into from
Jun 23, 2021
Merged

Conversation

curtiseppel
Copy link

MSK now supports IAM access control for client authentication with a MSK
cluster.
https://aws.amazon.com/about-aws/whats-new/2021/05/introducing-iam-access-control-amazon-msk/


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented May 12, 2021

@github-actions github-actions bot added @aws-cdk/aws-iam Related to AWS Identity and Access Management @aws-cdk/aws-msk Related to Amazon Managed Streaming for Apache Kafka (Amazon MSK) labels May 12, 2021
@iliapolo iliapolo added effort/small Small work item – less than a day of effort p2 response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. and removed @aws-cdk/aws-iam Related to AWS Identity and Access Management labels May 17, 2021
@mergify mergify bot dismissed iliapolo’s stale review June 10, 2021 03:50

Pull request has been modified.

@curtiseppel curtiseppel requested a review from iliapolo June 10, 2021 06:00
@peterwoodworth peterwoodworth removed the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Jun 11, 2021
@iliapolo
Copy link
Contributor

@curtiseppel Can I ask you to resolve the conflicts so the diff is up to date? Thanks!

@iliapolo iliapolo added the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Jun 20, 2021
Copy link
Contributor

@iliapolo iliapolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@curtiseppel PR looks good. But build is still failing. Happy to approve after the build passes.

Got mixed up in the previous merge commit
@mergify mergify bot dismissed iliapolo’s stale review June 23, 2021 06:44

Pull request has been modified.

@iliapolo iliapolo changed the title feat(msk): support IAM access control for msk clusters feat(msk): IAM access control for msk clusters Jun 23, 2021
@iliapolo iliapolo changed the title feat(msk): IAM access control for msk clusters feat(msk): IAM access control clusters Jun 23, 2021
@iliapolo iliapolo changed the title feat(msk): IAM access control clusters feat(msk): IAM access control for clusters Jun 23, 2021
@iliapolo iliapolo removed the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Jun 23, 2021
@mergify
Copy link
Contributor

mergify bot commented Jun 23, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: a2f4ba1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 1fe680c into aws:master Jun 23, 2021
@mergify
Copy link
Contributor

mergify bot commented Jun 23, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
MSK now supports IAM access control for client authentication with a MSK
cluster.
https://aws.amazon.com/about-aws/whats-new/2021/05/introducing-iam-access-control-amazon-msk/


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@gmuslia
Copy link
Contributor

gmuslia commented May 24, 2024

As far as I can see from the UI the MSK can have both enabled, IAM and SASL/SCRAM, any ideas why we do not allow this in the CDK Level?
Screenshot 2024-05-24 at 15 17 34

@msambol
Copy link
Contributor

msambol commented Oct 14, 2024

@gmuslia Looks like a bug here with the if/else if. It's a little weird how CloudFormation grouped IAM and SCRAM under SASL. I'll see if I can work on a fix.

@curtiseppel Not sure how involved you are with CDK anymore but jfyi 😄

@msambol
Copy link
Contributor

msambol commented Oct 14, 2024

I think this should do it: #31743

cc/ @gmuslia @curtiseppel

mergify bot pushed a commit that referenced this pull request Feb 8, 2025
Pointed out [here](#14647 (comment)) and verified in the Console, both `SASL/SCRAM` and `IAM` can be enabled together.

Closes #32779

It's a little confusing because [CloudFormation](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-msk-cluster-sasl.html) groups `Iam` and `Scram` together under `Sasl`, 
but the Console separates the two and allows both at the same time. I'd like to refactor this further but 
this change unblocks the issue where `SASL/SCRAM` and `IAM` cannot be enabled together.

![image](https://github.com/user-attachments/assets/60dd662e-4db9-4bbb-bcc0-67bd059f6870)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-msk Related to Amazon Managed Streaming for Apache Kafka (Amazon MSK) effort/small Small work item – less than a day of effort p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants