Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(assets): tarball path should be absolute #15750

Merged
merged 5 commits into from
Sep 12, 2021
Merged

docs(assets): tarball path should be absolute #15750

merged 5 commits into from
Sep 12, 2021

Conversation

eladb
Copy link
Contributor

@eladb eladb commented Jul 25, 2021

Improve docs to indicate that the path to a tarball should be absolute and not relative.

Fixes #15721


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jul 25, 2021

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jul 25, 2021
@chris-leach
Copy link

While this might be an improvement to the docs, it is unrelated to #15721 - see comment.

@rix0rrr rix0rrr changed the title fix(ecr-assets): docs issue: tarball path should be absolute docs(assets): tarball path should be absolute Sep 7, 2021
@mergify
Copy link
Contributor

mergify bot commented Sep 12, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 0ec9f61
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit a732078 into master Sep 12, 2021
@mergify mergify bot deleted the eladb-patch-1 branch September 12, 2021 11:30
@mergify
Copy link
Contributor

mergify bot commented Sep 12, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
4 participants