fix(autoscaling): EbsDeviceVolumeType.IO2 is not a valid CloudFormation value

[jumic]

Remove value IO2 from enum EbsDeviceVolumeType because it is not supported in CloudFormation.

Fixes #16027.

Please double-check before approving: Value from enum is removed which could potentially be a breaking change. However, it's an invalid value. Therefore, it should be correct to remove it.

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[gitpod-io]

[jumic]

PR Linter failed with "Fixes must contain a change to a test file". Could we skip this for this issue? I think there is no test case that makes sense here.

[peterwoodworth]

Thanks! But closing for reason mentioned in the issue

[peterwoodworth]

Looks like the build is failing.

@rix0rrr I'll leave this issue to you. tl;dr PR #12074 created the io2 option in ec2's and Autoscaling's enums EbsDeviceVolumeType, however this only should have been created in the ec2 enum because io2 isn't supported for autoscaling.

[jumic]

I fixed the build by adding the change to the breaking changes file.
Do I also have to declare this PR as a breaking change? From a technical point of view, it is a breaking change, because the value will be removed. However, this value was never supported. Therefore, I'm not sure how it will be handled.

[rix0rrr]

You are right. Let's allow the breaking change for now, we can always roll back if it causes problems.

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
• Commit ID: fa2e5ae
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).