fix(cloudformation-diff): cdk diff not picking up differences if old/new value is in format n.n.n #16050
Conversation
|
|
peterwoodworth
added
@aws-cdk/cloudformation-diff
effort/small
|
We just hit this bug, but with IP-addresses when working with WAF IP Sets. Changes to the two last octets are not picked up (e.g. changing IP from 1.1.1.1 to 1.1.2.2). I don't think your patch fixes this edge case either, the regex could probably be changed to only allow one dot in a float? |
…/aws-cdk into aws-config-parsefloat-fix
mergify
bot
dismissed
BenChaimberg’s stale review
Pull request has been modified.
packages/@aws-cdk/cloudformation-diff/test/diff-template.test.ts
Outdated
Show resolved
Hide resolved
BenChaimberg
changed the title
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
"cdk diff" in the current version doesn't pick up differences if the old/new value has a number-like format but actually isn't a number (e.g. 0.31.1)
Example: two version strings like "0.31.1-prod" and "0.31.2-prod" are both parsed into "0.31" (and hence incorrectly considered equal).
Closes #15935.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license