feat(assertions): capture matching value #16426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 8, 2021 17:49
|
|
rix0rrr
previously requested changes
Sep 9, 2021
packages/@aws-cdk/pipelines/test/compliance/basic-behavior.test.ts
Outdated
Show resolved
Hide resolved
nija-at
force-pushed
the
nija-at/assertions-capture
branch
from
4b2302e
to
ffa9eab
Compare
rix0rrr
approved these changes
Sep 9, 2021
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
BenChaimberg
reviewed
Sep 9, 2021
Comment on lines
+351
to
+352
| fredCapture.asArray(); // returns ["Flob", "Cat"] | ||
| waldoCapture.asString(); // returns "Qux" |
There was a problem hiding this comment.
I would appreciate a more "useful" example here that demonstrates the benefit of using capturing. We can use the assertion found in the pipelines module like expect(captured.asString().length()).toBe(3) or something
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
assertionsmodule now has the ability to capture valuesduring template matching. These captured values can then later
be retrieved and used for further processing.
This change also adds support for
anyValue()matcher. Thismatcher will match any non-nullish targets during template
matching.
Migrated some tests in
pipelinesmodule to theassertionsmodule, using the new capture and
anyValue()features.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license