feat(pipeline): allow enabling KMS key rotation for cross-region Stacks

[pboeder]

As suggested by @skinny85 I created an updated PR as successor of #14381

How does it work for v2. Do I need to create another PR for v2-main?

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[gitpod-io]

[skinny85]

Thanks for the contribution @ppuritscher!

Like I said in the previous Pull Request (#14381 (comment)), we should strive to minimize the changes to existing templates, and so we should not default enableKeyRotation to false; instead, we should leave it as undefined if it was not provided. This will have the consequence of not having to change all of the integration test files that you have currently changed in the PR (you'll be able to revert those changes).

Other than that, the changes look good!

Pull request has been modified.

[pboeder]

@skinny85 overread that. Fixed, thanks for the feedback!

[skinny85]

Looks good @ppuritscher, but I still want to see a few changes before this is merged in 🙂.

Pull request has been modified.

[pboeder]

Makes sense, thanks @skinny85!

Pull request has been modified.

[skinny85]

@ppuritscher I think we're not understanding each other, so I'll try to spell out what I want to see here as clearly as I can 🙂.

Please revert all changes to the file packages/@aws-cdk/aws-codepipeline/README.md besides the one paragraph that talks about the new property.

If it's still unclear how to do it:

1. Open the file packages/@aws-cdk/aws-codepipeline/README.md in your editor.
2. Cut out the following paragraph:

If you want to enable key rotation for the generated KMS keys,
you can configure it by passing `enableKeyRotation: true` when creating the pipeline.
Note that key rotation will incur an additional cost of **$1/month**.

```ts
const pipeline = new codepipeline.Pipeline(this, 'MyFirstPipeline', {
  // ...
  enableKeyRotation: true,
});
```

3. Execute the following command in the root of the project:

$ git checkout origin/master -- packages/@aws-cdk/aws-codepipeline/README.md

This will discard all changes to that file.

4. Copy back the paragraph you cut out in step 2 into the same place you cut it from in the packages/@aws-cdk/aws-codepipeline/README.md file.
5. Commit the result, & push to your fork to update the PR.

Hope this is clear now!

Thanks,
Adam

[pboeder]

Hi @skinny85 !

You're right, sorry. Was only looking on the diffs your commenting on.
Also helps disable any plugins in vscode...

Patrick

[pboeder]

Yep. Messed up the rebase. Will fix and get back to you.

[skinny85]

Looks great @ppuritscher, thanks for the contribution!

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
• Commit ID: 3bf5dd1
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).