Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws-logs): include new policy.ts exports in index.ts exports #17403

Merged

Conversation

ryparker
Copy link
Contributor

@ryparker ryparker commented Nov 8, 2021

Summary

This PR modifies the aws-logs index.ts file to also forward the exports from policy.ts (a newly created file that implements the ResourcePolicy class).

Fixes: #17402

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Nov 8, 2021

@github-actions github-actions bot added the @aws-cdk/aws-logs Related to Amazon CloudWatch Logs label Nov 8, 2021
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 8, 2021
Copy link
Contributor

@peterwoodworth peterwoodworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR got through because no tests were added which create a ResourcePolicy. Basic tests for this resource should be added

Copy link
Contributor

@peterwoodworth peterwoodworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I specifically meant a test which creates a ResourcePolicy directly as described in the docs https://docs.aws.amazon.com/cdk/api/latest/docs/aws-logs-readme.html#resource-policy

@ryparker
Copy link
Contributor Author

ryparker commented Nov 8, 2021

I specifically meant a test which creates a ResourcePolicy directly as described in the docs docs.aws.amazon.com/cdk/api/latest/docs/aws-logs-readme.html#resource-policy

Ah gotcha. Done 👍🏻

@mergify
Copy link
Contributor

mergify bot commented Nov 8, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Nov 9, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 890549d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit a391468 into master Nov 9, 2021
@mergify mergify bot deleted the fix-new-resourcepolicy-construct-not-exported-from-index branch November 9, 2021 20:30
@mergify
Copy link
Contributor

mergify bot commented Nov 9, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
…ws#17403)

## Summary

This PR modifies the aws-logs `index.ts` file to also forward the exports from `policy.ts` ([a newly created file](aws#17015) that implements the `ResourcePolicy` class).

Fixes: aws#17402
----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-logs Related to Amazon CloudWatch Logs contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(log): New ResourcePolicy construct not exported from index.js
4 participants