-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(aws-logs): include new policy.ts
exports in index.ts
exports
#17403
fix(aws-logs): include new policy.ts
exports in index.ts
exports
#17403
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR got through because no tests were added which create a ResourcePolicy
. Basic tests for this resource should be added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I specifically meant a test which creates a ResourcePolicy
directly as described in the docs https://docs.aws.amazon.com/cdk/api/latest/docs/aws-logs-readme.html#resource-policy
Ah gotcha. Done 👍🏻 |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…ws#17403) ## Summary This PR modifies the aws-logs `index.ts` file to also forward the exports from `policy.ts` ([a newly created file](aws#17015) that implements the `ResourcePolicy` class). Fixes: aws#17402 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Summary
This PR modifies the aws-logs
index.ts
file to also forward the exports frompolicy.ts
(a newly created file that implements theResourcePolicy
class).Fixes: #17402
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license