fix(iam): AWS Managed Policy ARNs are not deduped #17623
Conversation
Managed Policy ARNs should be deduped when added to a Role, otherwise the deployment is going to fail. Remove the unnecessary use of `Lazy.uncachedString` to make sure that the ARNs of two `ManagedPolicy.fromAwsManagedPolicyName()` policies are consistent. Fixes #17552.
github-actions
bot
added
the
@aws-cdk/aws-iam
packages/@aws-cdk/core/lib/arn.ts
Outdated
| const region = components.region ?? stack?.region; | ||
| const account = components.account ?? stack?.account; | ||
|
|
||
| if (partition === undefined || region === undefined || account === undefined) { |
There was a problem hiding this comment.
Test for this?
Also, what about null or empty strings?
There was a problem hiding this comment.
Ack.
Empty string is fine, I'll catch null as well.
|
|
|
Hi folks, |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Managed Policy ARNs should be deduped when added to a Role, otherwise the deployment is going to fail. Remove the unnecessary use of `Lazy.uncachedString` to make sure that the ARNs of two `ManagedPolicy.fromAwsManagedPolicyName()` policies are consistent. Fixes aws#17552. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Managed Policy ARNs should be deduped when added to a Role,
otherwise the deployment is going to fail.
Remove the unnecessary use of
Lazy.uncachedStringto make sure thatthe ARNs of two
ManagedPolicy.fromAwsManagedPolicyName()policiesare consistent.
Fixes #17552.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license