chore: update contract for registerContextProvider #17954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're trialling open context providers internally. Not ready yet to call this a public API but we will maintain firmer guarantees on this function going forward.
|
|
rix0rrr
changed the title
NetaNir
approved these changes
Dec 10, 2021
github-actions
bot
added
the
@aws-cdk/custom-resources
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Excited to see an API like this moving forward! A few growing pains I've seen could absolutely have been solved via a custom Context Provider. Ready to play with the bits as soon as this is more stable! |
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
We're trialling open context providers internally. Not ready yet to call this a public API but we will maintain firmer guarantees on this function going forward. Issues already uncovered by doing this that the more general open framework will have to deal with: * `SdkProvider` would need to be open and stable * What if the provider doesn't need account/region? * Schema validation in query and response * Side channel instructions to the context framework * (not to mention: how will the code get on the user's machine?) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're trialling open context providers internally. Not ready yet to call this a public API but we will maintain firmer guarantees on this function going forward.
Issues already uncovered by doing this that the more general open framework will have to deal with:
SdkProviderwould need to be open and stableBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license