Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rds): add MariaDB 10.5.13, 10.4.22, 10.3.32, 10.2.41 and Aurora MySQL 3.01.0 #17959

Merged
merged 3 commits into from
Dec 13, 2021

Conversation

jumic
Copy link
Contributor

@jumic jumic commented Dec 10, 2021

Add new RDS versions:

MariaDbEngineVersion 10.5.13, 10.4.22, 10.3.32 and 10.2.41
Announcement

AuroraMysqlEngineVersion 3.01.0
Announcement
Version informations retrieved from CLI command: aws rds describe-db-engine-versions --region us-east-1 --engine aurora-mysql --engine-version 8.0

Deployment tested successfully:

new rds.DatabaseCluster(this, 'DatabaseCluster', {
  engine: rds.DatabaseClusterEngine.auroraMysql({ version: rds.AuroraMysqlEngineVersion.VER_3_01_0 }),
  instanceProps: {
    instanceType: ec2.InstanceType.of(ec2.InstanceClass.R5, ec2.InstanceSize.XLARGE),
    vpc,
  },
  removalPolicy: RemovalPolicy.DESTROY,
});

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Dec 10, 2021

@github-actions github-actions bot added the @aws-cdk/aws-rds Related to Amazon Relational Database label Dec 10, 2021
@mergify
Copy link
Contributor

mergify bot commented Dec 10, 2021

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@jumic jumic changed the title add MariaDB 10.5.13, 10.4.22, 10.3.32, 10.2.41 and Aurora MySQL 3.01.0 chore(rds): add MariaDB 10.5.13, 10.4.22, 10.3.32, 10.2.41 and Aurora MySQL 3.01.0 Dec 10, 2021
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @jumic! A tiny change please before we merge this in 🙂.

packages/@aws-cdk/aws-rds/lib/cluster-engine.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-rds/test/cluster-engine.test.ts Outdated Show resolved Hide resolved
@mergify mergify bot dismissed skinny85’s stale review December 11, 2021 09:19

Pull request has been modified.

@jumic
Copy link
Contributor Author

jumic commented Dec 11, 2021

Thanks for your review. I implemented the suggested changes.

@jumic jumic requested a review from skinny85 December 11, 2021 09:20
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @jumic!

@mergify
Copy link
Contributor

mergify bot commented Dec 13, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: fbab67b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit afcaede into aws:master Dec 13, 2021
@mergify
Copy link
Contributor

mergify bot commented Dec 13, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
… MySQL 3.01.0 (aws#17959)

Add new RDS versions:

**MariaDbEngineVersion 10.5.13, 10.4.22, 10.3.32 and 10.2.41**
[Announcement](https://aws.amazon.com/about-aws/whats-new/2021/12/amazon-rds-mariadb-supports-new-minor-versions/)

**AuroraMysqlEngineVersion 3.01.0**
[Announcement](https://aws.amazon.com/about-aws/whats-new/2021/11/amazon-aurora-mysql-8-0/)
Version informations retrieved from CLI command: `aws rds describe-db-engine-versions --region us-east-1 --engine aurora-mysql --engine-version 8.0`

Deployment tested successfully:
```ts
new rds.DatabaseCluster(this, 'DatabaseCluster', {
  engine: rds.DatabaseClusterEngine.auroraMysql({ version: rds.AuroraMysqlEngineVersion.VER_3_01_0 }),
  instanceProps: {
    instanceType: ec2.InstanceType.of(ec2.InstanceClass.R5, ec2.InstanceSize.XLARGE),
    vpc,
  },
  removalPolicy: RemovalPolicy.DESTROY,
});
```

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-rds Related to Amazon Relational Database
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants