-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): support SSO #19454
Merged
Merged
feat(cli): support SSO #19454
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
f12a0ac
rewrite Construct imports
comcalvi 03c3a26
undo
comcalvi 27437e8
Merge branch 'master' of github.com:aws/aws-cdk
comcalvi 0d43399
Merge branch 'master' of github.com:aws/aws-cdk
comcalvi 6d8f6d9
Merge branch 'master' of github.com:aws/aws-cdk
comcalvi 71a9596
Merge branch 'master' of github.com:aws/aws-cdk
comcalvi 182635f
Merge branch 'master' of github.com:aws/aws-cdk
comcalvi 841ab25
added sso support to cdk
comcalvi 2e1b803
Merge branch 'master' of github.com:aws/aws-cdk into sso-support
comcalvi c5e3153
changed sso creds object name
comcalvi 7972f52
added unit test
comcalvi 7c9884c
updated sdk dependency
comcalvi 24df923
Merge branch 'master' of github.com:aws/aws-cdk into sso-support
comcalvi 17348cd
fixed comiplation type checking issue
comcalvi 30768d6
AWS_PROFILE now loads it
comcalvi 504a56c
removed tests
comcalvi 47b4d93
yarn.lock
comcalvi 11a9a01
readme
comcalvi b4d7c18
removed conditional credential loading
comcalvi 5d36999
fixed test
comcalvi 00da3f7
removed brace
comcalvi 778a58b
merge conflicts
comcalvi 7f99bc1
yarn pkglint (again)
comcalvi 0cccd51
Refactor, version bump
rix0rrr e322095
Merge remote-tracking branch 'origin/master' into pr/comcalvi/19454
rix0rrr c44e364
Remove duplication
rix0rrr e0cf8b1
Licenses take 2358925
rix0rrr d61de2b
Merge branch 'master' into sso-support
mergify[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @comcalvi, is there a reason why credentials from the profile would take precedence here over the SSO? It's different than e.g. behavior of JS SDK v3 - https://github.com/aws/aws-sdk-js-v3/blob/31e72ac6063fdb3393c2d5042b8964238ce1b23a/packages/credential-provider-node/src/defaultProvider.ts#L52-L54
Or am I missing something here?