feat(lambda): Migrate away from NODEJS_10_X and NODEJS_12_X to NODEJS_14_X #20531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This is a very chunky PR 🤣
P.S. See you again when |
|
Affected packages @aws-cdk-containers/ecs-service-extensions
@aws-cdk/aws-amplify
@aws-cdk/aws-apigateway
@aws-cdk/aws-apigatewayv2-authorizers
@aws-cdk/aws-apigatewayv2-integrations
@aws-cdk/aws-appsync
@aws-cdk/aws-autoscaling-hooktargets
@aws-cdk/aws-chatbot
@aws-cdk/aws-cloudformation
@aws-cdk/aws-cloudfront
@aws-cdk/aws-cloudtrail
@aws-cdk/aws-codedeploy
@aws-cdk/aws-codepipeline-actions
@aws-cdk/aws-cognito
@aws-cdk/aws-config
@aws-cdk/aws-dynamodb-global
@aws-cdk/aws-dynamodb
@aws-cdk/aws-ec2
@aws-cdk/aws-ecs
@aws-cdk/aws-eks
@aws-cdk/aws-events-targets
@aws-cdk/aws-globalaccelerator-endpoints
@aws-cdk/aws-glue
@aws-cdk/aws-iam
@aws-cdk/aws-iot-actions
@aws-cdk/aws-iot
@aws-cdk/aws-iotevents-actions
@aws-cdk/aws-kinesisfirehose-destinations
@aws-cdk/aws-kinesisfirehose
@aws-cdk/aws-lambda-destinations
@aws-cdk/aws-lambda-event-sources
@aws-cdk/aws-lambda-nodejs
@aws-cdk/aws-lambda-python
@aws-cdk/aws-lambda
@aws-cdk/aws-logs-destinations
@aws-cdk/aws-logs
@aws-cdk/aws-msk
@aws-cdk/aws-opensearchservice
@aws-cdk/aws-rds
@aws-cdk/aws-redshift
@aws-cdk/aws-route53-targets
@aws-cdk/aws-route53
@aws-cdk/aws-s3-deployment
@aws-cdk/aws-s3-notifications
@aws-cdk/aws-s3
@aws-cdk/aws-s3objectlambda
@aws-cdk/aws-secretsmanager
@aws-cdk/aws-ses-actions
@aws-cdk/aws-ses
@aws-cdk/aws-sns-subscriptions
@aws-cdk/aws-stepfunctions-tasks
@aws-cdk/cloudformation-include
@aws-cdk/core
@aws-cdk/custom-resources
@aws-cdk/integ-runner
@aws-cdk/integ-tests
@aws-cdk/lambda-layer-awscli
@aws-cdk/pipelines
@aws-cdk/triggers
aws-cdk-lib
aws-cdk |
jogold
approved these changes
May 30, 2022
|
Oh oops. This is a bit of a blocker. We can't really afford to break Chinese (or GovCloud) customers 😔 |
|
@rix0rrr Got it. We can put this PR in the backlog and revisit it once GovCloud and Chinese regions catch up. |
This was referenced Jun 1, 2022
robertd
changed the title
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
github-actions
bot
added
bug
|
It looks like |
|
I'm planning on starting over on this PR when time permits... too many changes happening at the same time for this PR to stay clean (master to main switchover, yarn-integ updates, nodejs16 to nodejs14 "downgrade"... etc). |
4 tasks
mergify bot
pushed a commit
that referenced
this pull request
Jun 3, 2022
…_14_X (#20595) Spiritual successor of #20531 <img width="487" alt="Screen Shot 2022-06-01 at 9 08 18 PM" src="https://user-images.githubusercontent.com/31543/171552028-7153063a-1c19-4972-ab89-6f280a4e9326.png"> - Migrated away (tests, docs, internal use) from NODEJS_10_X to NODEJS_14_X - Migrated away (tests, docs, internal use) from NODEJS_12_X to NODEJS_14_X - Added NODEJS_16_X to CustomResources - Update CustomResources to use nodejs14.x by default - Updated integration tests across the board. Some integ tests introduced destructive changes (expected with change of nodejs runtime) Closes #20568 Closes #19992 Closes #20474 ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
daschaa
pushed a commit
to daschaa/aws-cdk
that referenced
this pull request
Jul 9, 2022
…_14_X (aws#20595) Spiritual successor of aws#20531 <img width="487" alt="Screen Shot 2022-06-01 at 9 08 18 PM" src="https://user-images.githubusercontent.com/31543/171552028-7153063a-1c19-4972-ab89-6f280a4e9326.png"> - Migrated away (tests, docs, internal use) from NODEJS_10_X to NODEJS_14_X - Migrated away (tests, docs, internal use) from NODEJS_12_X to NODEJS_14_X - Added NODEJS_16_X to CustomResources - Update CustomResources to use nodejs14.x by default - Updated integration tests across the board. Some integ tests introduced destructive changes (expected with change of nodejs runtime) Closes aws#20568 Closes aws#19992 Closes aws#20474 ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
@robertd do you know when will node16 support be available? date / release? |
|
@alexherriott Node16 support is already in place #20261 |
|
thanks Robert |
|
Ah gotcha… That would be a gigantic PR effort (like this one). Sometime soon I guess :) |
|
Also, we need to check and see if nodejs16 is available in all regions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20568
Closes #19992
Closes #20474
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license