feat(appsync): allow user to configure log retention time

[nikovirtala]

This pull request implements a feature that allows users to configure the log retention period for App Sync logs.

AWS AppSync doesn't allow users to use user-defined log groups, leaving the option to create the log group for the user and set the retention time accordingly. Fortunately, the service always creates its log groups according to a pre-defined naming convention.

The log group is named following the /aws/appsync/apis/{graphql_api_id} format

ref. https://docs.aws.amazon.com/appsync/latest/devguide/monitoring.html

At the same time, AWS CDK provides a stable construct to set log retention times for any log group.

Thus, it is completely unnecessary to force every user to learn this detail when it can be abstracted to the construct creating the resource for them – that is what this pull request aims to do.

---

All Submissions:

• Have you followed the guidelines in our Contributing guide?

Adding new Unconventional Dependencies:

• This PR adds new unconventional dependencies following the process described here

New Features

• Have you added the new feature to an integration test?
  • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[gitpod-io]

[nikovirtala]

The pull request validation workflow fails on: Error: Features must contain a change to a README file.

Currently, the README file doesn't say a word about logging 😄 – do you have any specific wishes for the content I should add there? Just a couple of words about the log retention or something generally about the logging options (and log retention)?

[corymhall]

The pull request validation workflow fails on: Error: Features must contain a change to a README file.

Currently, the README file doesn't say a word about logging 😄 – do you have any specific wishes for the content I should add there? Just a couple of words about the log retention or something generally about the logging options (and log retention)?

I would add something like what we have for aws-lambda https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_lambda-readme.html#log-group

[corymhall]

Looks great! I think the only thing that is missing is an integration test.

[nikovirtala]

Looks great! I think the only thing that is missing is an integration test.

I guess it is time to learn to write integration tests then! There seem to be plenty of examples available, so it shouldn't be a big problem.

Pull request has been modified.

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 8af6c70
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[TheRealAmazonKendra]

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.