Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(glue): refresh links for aws glue documentation #20577

Merged
merged 3 commits into from
Jun 2, 2022

Conversation

daschaa
Copy link
Contributor

@daschaa daschaa commented Jun 1, 2022

Fixes #20546

Refreshes the links in the AWS Glue docs pointing to the Apache Hive website (for more information see the issue #20546 )


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jun 1, 2022

@daschaa daschaa changed the title 📝 docs(glue): refresh links for aws glue docs(glue): refresh links for aws glue documentation Jun 1, 2022
@github-actions github-actions bot added effort/small Small work item – less than a day of effort p2 labels Jun 1, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team June 1, 2022 18:07
@daschaa
Copy link
Contributor Author

daschaa commented Jun 1, 2022

@kaizencc Can you review this PR too please? :)
I think you would be a good fit, since you suggested the URL change in the original issue.

Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @daschaa! I'm not going to approve this yet because we are in flux today moving default branches -- you should be able to quickly change your target branch after this change is in, but I'll let you know when we're done changing the branches.

@TheRealAmazonKendra TheRealAmazonKendra changed the base branch from v1-main to main June 2, 2022 08:54
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Targeting main now because that's our new default branch.

@mergify
Copy link
Contributor

mergify bot commented Jun 2, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@daschaa
Copy link
Contributor Author

daschaa commented Jun 2, 2022

@kaizencc Is it stuck somehow? Seems like the automatic merge of the main branch is not happening. 🤔

@mergify
Copy link
Contributor

mergify bot commented Jun 2, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 59afc00
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit b9065a5 into aws:main Jun 2, 2022
@mergify
Copy link
Contributor

mergify bot commented Jun 2, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

daschaa added a commit to daschaa/aws-cdk that referenced this pull request Jul 9, 2022
Fixes aws#20546

Refreshes the links in the AWS Glue docs pointing to the Apache Hive website (for more information see the issue aws#20546 )

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/small Small work item – less than a day of effort p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(glue): broken links
3 participants