feat(ecs-patterns): refactor fargate interfaces and add support for runtimePlatform #21529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
effort/small
TheRealAmazonKendra
changed the title
TheRealAmazonKendra
changed the title
|
@michaeldrey I don't think I have any notes here. Once you add in the README update, this seems like a no brainer and like it's just ready to go. I suppose I'd like it if you added the other tests into this one that you had in the closed one, but those might(?) be redundant with this refactor. I am changing this to a feat since it's adding functionality that we'd want in the changelog, but I have no requested changes to the code at this time. |
TheRealAmazonKendra
previously requested changes
Aug 10, 2022
mergify
bot
dismissed
TheRealAmazonKendra’s stale review
Pull request has been modified.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
TheRealAmazonKendra
approved these changes
Aug 10, 2022
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
josephedward
pushed a commit
to josephedward/aws-cdk
that referenced
this pull request
Aug 30, 2022
…untimePlatform (aws#21529) Stemming from aws#20756, currently there are a lot of duplicated Fargate props throughout the library ie `cpu`, `memory`. This can make adding Fargate properties tedious as you have to add them into every Fargate type. This PR introduces `FargateServiceBaseProps` which will hold all of the common Fargate properties and allows all Fargate variations to inherit from. As an example, I have added in `runtimePlatform` to all Fargate services. I still need to make a small README update, but want to get this pushed up for thoughts/suggestions/feedback. closes aws#20756 aws#18462 ---- ### All Submissions: * [x ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stemming from #20756, currently there are a lot of duplicated Fargate props throughout the library ie
cpu,memory. This can make adding Fargate properties tedious as you have to add them into every Fargate type.This PR introduces
FargateServiceBasePropswhich will hold all of the common Fargate properties and allows all Fargate variations to inherit from.As an example, I have added in
runtimePlatformto all Fargate services.I still need to make a small README update, but want to get this pushed up for thoughts/suggestions/feedback.
closes #20756 #18462
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license