docs(lambda): Document recent changes to vpcSubnets property
#21572
Conversation
|
|
|
If documentation isn't sufficient and this is determined to be breaking change (it was discussed in #21369 and despite the new error being thrown, it was determined not be since it didn't result in changes to the created infrastructure) and the original PR needs to be reverted, that'd be unfortunate but understandable. If that is the case, I'll instead open a separate issue to ask about using a warning Annotation by default in this case and using a feature flag to re-add the |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…1572) Recently, the Function construct was changed to raise an error if `vpcSubnets` was specified but `vpc` wasn't; however, this change was not properly reflected in the documentation for the function. The change itself was made in aws#21369. Closes aws#21565 ---- ### All Submissions: * [X] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Recently, the Function construct was changed to raise an error if
vpcSubnetswas specified butvpcwasn't; however, this change wasnot properly reflected in the documentation for the function. The change
itself was made in #21369.
Closes #21565
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license