Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "feat(cli): --concurrency option" #21664

Merged
merged 3 commits into from
Aug 18, 2022
Merged

Revert "feat(cli): --concurrency option" #21664

merged 3 commits into from
Aug 18, 2022

Conversation

Naumel
Copy link
Contributor

@Naumel Naumel commented Aug 18, 2022

Reverts #20345

See #21661

@gitpod-io
Copy link

gitpod-io bot commented Aug 18, 2022

@github-actions github-actions bot added the p2 label Aug 18, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 18, 2022
@Naumel Naumel marked this pull request as draft August 18, 2022 16:43
@Naumel Naumel marked this pull request as ready for review August 18, 2022 16:43
@Naumel Naumel mentioned this pull request Aug 18, 2022
Merged
@aws-cdk-automation aws-cdk-automation requested a review from a team August 18, 2022 16:45
@mrgrain mrgrain added the pr/do-not-merge This PR should not be merged at this time. label Aug 18, 2022
mrgrain
mrgrain approved these changes Aug 18, 2022
View reviewed changes
Copy link
Contributor

@mrgrain mrgrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

mrgrain
mrgrain approved these changes Aug 18, 2022
View reviewed changes
Copy link
Contributor

@mrgrain mrgrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

@Naumel
Copy link
Contributor Author

Naumel commented Aug 18, 2022

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Aug 18, 2022

update

✅ Branch has been successfully updated

@Naumel
Copy link
Contributor Author

Naumel commented Aug 18, 2022

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Aug 18, 2022

update

✅ Branch has been successfully updated

@Naumel Naumel removed the pr/do-not-merge This PR should not be merged at this time. label Aug 18, 2022
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: ba2bce9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Aug 18, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 2ad2163 into main Aug 18, 2022
@mergify mergify bot deleted the revert-20345-relm/concurrent-deploys2 branch August 18, 2022 18:43
Naumel added a commit that referenced this pull request Aug 18, 2022
@Naumel
Revert "feat(cli): --concurrency option" (#21664)
39138eb 
Reverts #20345

See #21661
rix0rrr added a commit that referenced this pull request Aug 19, 2022
@rix0rrr
Revert "Revert "feat(cli): --concurrency option" (#21664)"
4da07fd 
This reverts commit 2ad2163.
@rix0rrr rix0rrr mentioned this pull request Aug 19, 2022
Merged
@rittneje rittneje mentioned this pull request Aug 21, 2022
Closed
mergify bot pushed a commit that referenced this pull request Aug 25, 2022
@rix0rrr
feat(cli): re-introduce --concurrency option (#21681)
f001f7e 
Re-rolls #20345, after it had to be reverted in #21664.

Includes the fix necessary to make sure that `--exclusively` works (#21663), and includes `cdk watch --concurrency` as well (#21598).

Closes #21663.
josephedward pushed a commit to josephedward/aws-cdk that referenced this pull request Aug 30, 2022
@Naumel @josephedward
Revert "feat(cli): --concurrency option" (aws#21664)
9182425 
Reverts aws#20345

See aws#21661
josephedward pushed a commit to josephedward/aws-cdk that referenced this pull request Aug 30, 2022
@rix0rrr @josephedward
feat(cli): re-introduce --concurrency option (aws#21681)
b1ea299 
Re-rolls aws#20345, after it had to be reverted in aws#21664.

Includes the fix necessary to make sure that `--exclusively` works (aws#21663), and includes `cdk watch --concurrency` as well (aws#21598).

Closes aws#21663.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrgrain mrgrain mrgrain approved these changes

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Naumel @aws-cdk-automation @mrgrain