Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): Fn::ToJsonString and Fn::Length intrinsic functions #21749

Merged
merged 5 commits into from
Aug 30, 2022
Merged

feat(core): Fn::ToJsonString and Fn::Length intrinsic functions #21749

merged 5 commits into from
Aug 30, 2022

Conversation

jogold
Copy link
Contributor

@jogold jogold commented Aug 25, 2022 •
edited
Loading

Add support for Fn::ToJsonString and Fn::Length.

The AWS::LanguageExtensions transform is automatically added.

See https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/intrinsic-function-reference-ToJsonString.html
See https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/intrinsic-function-reference-length.html
See https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/intrinsic-function-reference-transform.html

All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Aug 25, 2022

@jogold jogold changed the title feat(core): Fn::ToJsonString intrisic function feat(core): Fn::ToJsonString intrinsic function Aug 25, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team August 25, 2022 09:33
@github-actions github-actions bot added the p2 label Aug 25, 2022
@mrgrain mrgrain mentioned this pull request Aug 25, 2022
Closed
@jogold jogold changed the title feat(core): Fn::ToJsonString intrinsic function feat(core): Fn::ToJsonString and Fn::Length intrinsic functions Aug 25, 2022
jogold
jogold commented Aug 25, 2022
View reviewed changes
packages/@aws-cdk/core/lib/cfn-fn.ts
*
* @param array The array you want to return the number of elements from
*/
public static len(array: any): number {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cannot do public static length here.

Static property 'length' conflicts with built-in property 'Function.length' of constructor function 'Fn'.ts(2699)

@jogold
Copy link
Contributor Author

jogold commented Aug 25, 2022

Needs pr-linter/exempt-integ-test

TheRealAmazonKendra
TheRealAmazonKendra requested changes Aug 29, 2022
View reviewed changes
Copy link
Contributor

@TheRealAmazonKendra TheRealAmazonKendra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain why you think that integ tests aren't needed here? I think it would probably be good to add that test coverage.

@jogold
Copy link
Contributor Author

jogold commented Aug 29, 2022

Can you explain why you think that integ tests aren't needed here? I think it would probably be good to add that test coverage.

There are currently no integ tests in core, and I believe this would create a circular dependency @aws-cdk/core > @aws-cdk/integ-tests > @aws-cdk/core. Also I'm not sure it would bring much added value for a CF syntax.

@TheRealAmazonKendra
Copy link
Contributor

Can you explain why you think that integ tests aren't needed here? I think it would probably be good to add that test coverage.

There are currently no integ tests in core, and I believe this would create a circular dependency @aws-cdk/core > @aws-cdk/integ-tests > @aws-cdk/core. Also I'm not sure it would bring much added value for a CF syntax.

Hmm. I don't like that we don't have any tests for core, but adding them would very much be out of scope for this PR.

@TheRealAmazonKendra TheRealAmazonKendra added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Aug 30, 2022
@mergify
Copy link
Contributor

mergify bot commented Aug 30, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: d072670
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 7472fa4 into aws:main Aug 30, 2022
@mergify
Copy link
Contributor

mergify bot commented Aug 30, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@jogold jogold deleted the fn-tojsonstring branch August 30, 2022 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheRealAmazonKendra TheRealAmazonKendra TheRealAmazonKendra approved these changes

Assignees
No one assigned
Labels
p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jogold @TheRealAmazonKendra @aws-cdk-automation