feat(integ-tests): allow for user provided assertions stack

[dontirun]

Closes #22332

---

All Submissions:

• Have you followed the guidelines in our Contributing guide?

Adding new Unconventional Dependencies:

• This PR adds new unconventional dependencies following the process described here

New Features

• Have you added the new feature to an integration test?
  • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[gitpod-io]

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

[dontirun]

❌ Features must contain a change to an integration test file and the resulting snapshot.

Is that even possible in this case 😀?

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

[corymhall]

@dontirun thanks for picking this up!

[corymhall]

I think it might be better to actually allow the user to pass their own Stack. I think that is
what I originally intended to do. That also opens up the posibility to put the assertions in the
same Stack as your test stack.

[dontirun]

I like that a lot more! Let me refactor this PR

I also think it's beneficial in the case the user wanting to keep the stacks separated. It allows for creating lambda functions for the Lambda assertions independent from what is being integration tested

Pull request has been modified.

[dontirun]

Hmm, this needs some more changes...

  test('Circular structure error', () => {
    //GIVEN
    const app = new App();
    const assertionsStack = new Stack(app, 'AssertionsStack');

    //WHEN
    const integ = new IntegTest(app, 'integ', {
      testCases: [],
      assertionsStack: assertionsStack,
    });

    // THEN
    Template.fromStack(assertionsStack);
  });

    TypeError: Converting circular structure to JSON
        --> starting at object with constructor 'Stack'
        |     property 'node' -> object with constructor 'Node'
        --- property 'host' closes the circle
        at JSON.stringify (<anonymous>)

      178 |       withVersion = preprocess(withVersion);
      179 |     }
    > 180 |     fs.writeFileSync(filePath, JSON.stringify(withVersion, undefined, 2));
          |                                     ^
      181 |   }
      182 |
      183 |   private static loadManifest(filePath: string, schema: jsonschema.Schema, preprocess?: (obj: any) => any, options?: LoadManifestOptions) {

      at Function.saveManifest (../cloud-assembly-schema/lib/manifest.ts:180:37)
      at Function.saveIntegManifest (../cloud-assembly-schema/lib/manifest.ts:102:14)
      at Function.write (lib/manifest-writer.ts:9:14)
      at IntegManifestSynthesizer.synthesize (lib/manifest-synthesizer.ts:24:25)
      at Object.onSynthesize (lib/test-case.ts:183:25)
      at cb (../core/lib/private/synthesis.ts:188:15)
      at visit (../core/lib/private/synthesis.ts:230:5)
      at visit (../core/lib/private/synthesis.ts:226:5)
      at synthesizeTree (../core/lib/private/synthesis.ts:175:3)

[dontirun]

It was because of this line and generating the manifest. I got around this by just changing the property name from assertionsStack to assertionStack.

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 96faff8
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).