Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(apigateway): add single quotes to api.addGatewayResponse example code #22633

Merged
merged 4 commits into from
Oct 25, 2022
Merged

docs(apigateway): add single quotes to api.addGatewayResponse example code #22633

merged 4 commits into from
Oct 25, 2022

Conversation

yuyokk
Copy link
Contributor

@yuyokk yuyokk commented Oct 25, 2022

Hi team,

Spent some time struggling with issue described here #11306

Updating docs with working example.

Please check and let me know if this makes sense.
Thanks


All Submissions:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 labels Oct 25, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team October 25, 2022 10:47
@gitpod-io
Copy link

gitpod-io bot commented Oct 25, 2022

@yuyokk yuyokk changed the title Fix examples code on api.addGatewayResponse Fix example code on api.addGatewayResponse Oct 25, 2022
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

@yuyokk yuyokk changed the title Fix example code on api.addGatewayResponse fix: Add single quotes to values on api.addGatewayResponse example code Oct 25, 2022
@yuyokk yuyokk changed the title fix: Add single quotes to values on api.addGatewayResponse example code docs: Add single quotes to values on api.addGatewayResponse example code Oct 25, 2022
@aws-cdk-automation aws-cdk-automation dismissed their stale review October 25, 2022 10:54

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

@kaizencc kaizencc changed the title docs: Add single quotes to values on api.addGatewayResponse example code docs(apigateway): add single quotes to api.addGatewayResponse example code Oct 25, 2022
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding and fixing this example @yuyokk! I wonder if we can do better and add in these single quotes for the user if they are necessary, but this fix is good for now.

@mergify
Copy link
Contributor

mergify bot commented Oct 25, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 8d138fe
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 2fcc701 into aws:main Oct 25, 2022
@mergify
Copy link
Contributor

mergify bot commented Oct 25, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@yuyokk
Copy link
Contributor Author

yuyokk commented Oct 25, 2022

I wonder if we can do better and add in these single quotes for the user if they are necessary, but this fix is good for now.

@kaizencc please have a look at #22637

mergify bot pushed a commit that referenced this pull request Oct 25, 2022
…le quotes (#22637)

Hi team,

Here is a follow up to #22633

Please let me know if this makes sense.
Thanks

----

### All Submissions:

* [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants