-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(apigateway): add single quotes to api.addGatewayResponse
example code
#22633
Conversation
api.addGatewayResponse
api.addGatewayResponse
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
api.addGatewayResponse
api.addGatewayResponse
example code
api.addGatewayResponse
example codeapi.addGatewayResponse
example code
✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.
api.addGatewayResponse
example codeapi.addGatewayResponse
example code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for finding and fixing this example @yuyokk! I wonder if we can do better and add in these single quotes for the user if they are necessary, but this fix is good for now.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…le quotes (#22637) Hi team, Here is a follow up to #22633 Please let me know if this makes sense. Thanks ---- ### All Submissions: * [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Hi team,
Spent some time struggling with issue described here #11306
Updating docs with working example.
Please check and let me know if this makes sense.
Thanks
All Submissions:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license