Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add AWSLINT_SAVE to the PR buildspec #22743

Merged
merged 2 commits into from
Nov 2, 2022
Merged

Conversation

otaviomacedo
Copy link
Contributor


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Nov 2, 2022

@aws-cdk-automation aws-cdk-automation requested a review from a team November 2, 2022 15:17
@github-actions github-actions bot added the p2 label Nov 2, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 2, 2022
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 this is excellent :)

I really want to slap the approval on this but I can't seem to find where AWSLINT_SAVE will get used. I see the --save option in the awslint readme, but I don't see where it accepts env variables. What am I missing?

@otaviomacedo
Copy link
Contributor Author

🎉 this is excellent :)

I really want to slap the approval on this but I can't seem to find where AWSLINT_SAVE will get used. I see the --save option in the awslint readme, but I don't see where it accepts env variables. What am I missing?

yargs has this feature in which you set an env variable prefix. In this case, it's AWSLINT. Then everything after the prefix is interpreted as command line options. See https://yargs.js.org/docs/#api-reference-envprefix.

Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL!

@mergify
Copy link
Contributor

mergify bot commented Nov 2, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: fcb90fa
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit ea9ab4b into main Nov 2, 2022
@mergify mergify bot deleted the otaviom/awslint-save branch November 2, 2022 17:57
@mergify
Copy link
Contributor

mergify bot commented Nov 2, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

otaviomacedo added a commit that referenced this pull request Nov 4, 2022
mergify bot pushed a commit that referenced this pull request Nov 7, 2022
This reverts commit ea9ab4b.


----

### All Submissions:

* [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants