fix(aws-s3): adding support for underscore (_) in S3 bucket names as legacy bucket names can have underscores in their names #22992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s do possess underscores
|
|
github-actions
bot
added
p2
beginning-contributor
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
| @@ -1724,9 +1724,9 @@ export class Bucket extends BucketBase { | |||
| if (bucketName.length < 3 || bucketName.length > 63) { | |||
| errors.push('Bucket name must be at least 3 and no more than 63 characters'); | |||
| } | |||
| const charsetMatch = bucketName.match(/[^a-z0-9.-]/); | |||
| const charsetMatch = bucketName.match(/[^a-z0-9._-]/); | |||
There was a problem hiding this comment.
This method is used to validate the names of both imported buckets and buckets created in the app. But the underscore character should only be allowed when importing a bucket.
There was a problem hiding this comment.
Makes sense. I see that the pre-2018 bucket naming rules are as below:
Before March 1, 2018, buckets created in the US East (N. Virginia) Region could have names that were up to 255 characters long and included uppercase letters and underscores. Beginning March 1, 2018, new buckets in US East (N. Virginia) must conform to the same rules applied in all other Regions.
Seeing that this is a unique case only in us-east-1 and also has a further validation conditions like a longer length and capital letters being allowed, I do not think it makes sense to add a very specific validation check for this scenario. Closing the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes fix for issue: #22640
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license