Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lambda): automatic currentVersion conflicts with explicit Version resource #23636

Merged
merged 2 commits into from
Jan 11, 2023

Conversation

comcalvi
Copy link
Contributor

@comcalvi comcalvi commented Jan 10, 2023

In #23225, we automatically created a currentVersion Version object if the currentVersionOptions property was specified.

However, this breaks the case where a user both:

  • Specifies currentVersionOptions
  • Never calls currentVersion but instead creates a Version object directly.

In that case, 2 Version resources are created, but the second one fails because Lambda will not allow creating a new Version if nothing changed since the last Version.

Reverting that change.


All Submissions:

Adding new Construct Runtime Dependencies:

  • This PR adds new construct runtime dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@comcalvi comcalvi added the p0 label Jan 10, 2023
@gitpod-io
Copy link

gitpod-io bot commented Jan 10, 2023

@aws-cdk-automation aws-cdk-automation requested a review from a team January 10, 2023 18:59
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 10, 2023
@rix0rrr rix0rrr changed the title revert(lambda): Generates a version when currentVersionOptions is set fix(lambda): automatic currentVersion conflicts with explicit Version resource Jan 11, 2023
@mergify
Copy link
Contributor

mergify bot commented Jan 11, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 6cbae35
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit de68652 into aws:main Jan 11, 2023
@mergify
Copy link
Contributor

mergify bot commented Jan 11, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@SamStephens
Copy link
Contributor

@comcalvi it would have been much appreciated if you'd bothered to tag the original issue #23002 in this revert, as I've just wasted a lot of time trying to work out how the fix for that issue ended up being reverted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants