Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(glue): support Ray jobs #23822

Merged
merged 7 commits into from
Feb 9, 2023
Merged

feat(glue): support Ray jobs #23822

merged 7 commits into from
Feb 9, 2023

Conversation

moomindani
Copy link
Contributor

Glue launched a new job type: AWS Glue for Ray.
https://aws.amazon.com/about-aws/whats-new/2022/11/aws-glue-ray-preview/

This PR is to support the Ray job type in AWS CDK.


All Submissions:

Adding new Construct Runtime Dependencies:

  • This PR adds new construct runtime dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jan 25, 2023

@github-actions github-actions bot added p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Jan 25, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team January 25, 2023 00:32
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

@aws-cdk-automation aws-cdk-automation dismissed their stale review January 25, 2023 00:59

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

@moomindani
Copy link
Contributor Author

As far as I can see from CodeBuild log, I do not see any test case failures.
Only the issue I can find is rosetta script failure.

[Container] 2023/01/25 01:38:02 Command did not exit successfully /bin/bash ./scripts/run-rosetta.sh exit status 1
[Container] 2023/01/25 01:38:02 Phase complete: BUILD State: FAILED

Do we need to take any actions?

comcalvi
comcalvi previously approved these changes Feb 8, 2023
@mergify
Copy link
Contributor

mergify bot commented Feb 8, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed stale reviews from comcalvi February 9, 2023 16:01

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Feb 9, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 277eca4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 8de50d6 into aws:main Feb 9, 2023
@mergify
Copy link
Contributor

mergify bot commented Feb 9, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants