Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: "feat(redshift): column compression encodings and comments can now be customised" #24165

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

vinayak-kukreja
Copy link
Contributor

Reverts #23597 since it is failing in pipeline currently.

@gitpod-io
Copy link

gitpod-io bot commented Feb 14, 2023

@aws-cdk-automation aws-cdk-automation requested a review from a team February 14, 2023 14:15
@github-actions github-actions bot added the p2 label Feb 14, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Feb 14, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@vinayak-kukreja vinayak-kukreja changed the title Revert "feat(redshift): column compression encodings and comments can now be customised" revert: "feat(redshift): column compression encodings and comments can now be customised" Feb 14, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review February 14, 2023 14:22

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: d616923
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Feb 14, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 615e1ce into main Feb 14, 2023
@mergify mergify bot deleted the revert-23597-feature/commentting-encoding branch February 14, 2023 14:56
@Rizxcviii
Copy link
Contributor

Rizxcviii commented Feb 14, 2023

@vinayak-kukreja @corymhall Would I have to make another PR to get this merged again?

mergify bot pushed a commit that referenced this pull request Mar 8, 2023
…customised (#24177)

In accordance with #24165, I'm opening the same pull request as before. Not sure if my previous PR #23597 will automatically be "re-merged" in, but if not, then you can review this pull request

Will AGAIN close #22506

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
homakk pushed a commit to homakk/aws-cdk that referenced this pull request Mar 28, 2023
…customised (aws#24177)

In accordance with aws#24165, I'm opening the same pull request as before. Not sure if my previous PR aws#23597 will automatically be "re-merged" in, but if not, then you can review this pull request

Will AGAIN close aws#22506

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants