Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(servicecatalogappregistry): add attribute groups to an application #24672

Merged
merged 9 commits into from
Mar 22, 2023
Merged

feat(servicecatalogappregistry): add attribute groups to an application #24672

merged 9 commits into from
Mar 22, 2023

Commits on Mar 22, 2023

  1. Add associateNewAttributeGroup to create and associate the attribute … 

    …group to the application.

<body>

Testing done
-------------------------------------
*

Related items
------------------------------------
* SIM/auto-cut ticket
    @liwewang-amazon
    liwewang-amazon committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    570c77e View commit details
    Browse the repository at this point in the history

  2. Support create & associate attribute group in Application construct 

    <body>

Testing done
-------------------------------------
*

Related items
------------------------------------
* SIM/auto-cut ticket
    @liwewang-amazon
    liwewang-amazon committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    ddd8fab View commit details
    Browse the repository at this point in the history

  3. Change addAG param name 

    <body>

Testing done
-------------------------------------
*

Related items
------------------------------------
* SIM/auto-cut ticket
    @liwewang-amazon
    liwewang-amazon committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    aa97fd7 View commit details
    Browse the repository at this point in the history

  4. fix readme 

    <body>

Testing done
-------------------------------------
*

Related items
------------------------------------
* SIM/auto-cut ticket
    @liwewang-amazon
    liwewang-amazon committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    540af2e View commit details
    Browse the repository at this point in the history

  5. Updating samples with new input 

    Change Attribute Group construct ID generation from attribute group name. Change ApplicationAssociator application to a getter. Remove logical ID from addAttributeGroup props.

<body>

Testing done
-------------------------------------
*

Related items
------------------------------------
* SIM/auto-cut ticket
    @liwewang-amazon
    liwewang-amazon committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    80496d1 View commit details
    Browse the repository at this point in the history

  6. Add id into addAttributeGroup input to provide to AttributeGroup co… 

    …nstruct id.

<body>

Testing done
-------------------------------------
*

Related items
------------------------------------
* SIM/auto-cut ticket
    @liwewang-amazon
    liwewang-amazon committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    1dafe29 View commit details
    Browse the repository at this point in the history

  7. Change doc for addAttributeGroup method. 

    <body>

Testing done
-------------------------------------
*

Related items
------------------------------------
* SIM/auto-cut ticket
    @liwewang-amazon
    liwewang-amazon committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    f21f11b View commit details
    Browse the repository at this point in the history

  8. Make attribute group name as required. 

    <body>

Testing done
-------------------------------------
*

Related items
------------------------------------
* SIM/auto-cut ticket
    @liwewang-amazon
    liwewang-amazon committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    d4753c6 View commit details
    Browse the repository at this point in the history

  9. n to N 

    <body>

Testing done
-------------------------------------
*

Related items
------------------------------------
* SIM/auto-cut ticket
    @liwewang-amazon
    liwewang-amazon committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    07c0a1e View commit details
    Browse the repository at this point in the history