-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(region-info): EC2 service principal in Chia #24709
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
Exemption Request |
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Still an issue on 2.74.0 (latest python) |
Ya'll seem to break China like this every few months or so. AWS Partitions are a thing, China and GovCloud are the notable examples. I don't know what the situation is in AWS C2S (aka "spook-cloud"), but probably it's a similar deal. Given how deep-rooted and necessary this concept seems to be, I can't see it going away anytime soon. Next time somebody has a bright idea to optimise or get rid of |
EC2 service principal in Chia should be
ec2.amazonaws.com.cn
rather thanec2.amazonaws.com
.This feature was previously broke from #22589 and this PR fixes that.
Closes #24696
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license