Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(region-info): EC2 service principal in Chia #24709

Closed

Conversation

pahud
Copy link
Contributor

@pahud pahud commented Mar 20, 2023

EC2 service principal in Chia should be ec2.amazonaws.com.cn rather than ec2.amazonaws.com.

This feature was previously broke from #22589 and this PR fixes that.

Closes #24696


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Mar 20, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team March 20, 2023 23:34
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 20, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@pahud
Copy link
Contributor Author

pahud commented Mar 20, 2023

Exemption Request

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Mar 20, 2023
@pahud
Copy link
Contributor Author

pahud commented Mar 20, 2023

I can't find the document about this, but per the IAM console from AWS China, the service principal should be ec2.amazonaws.com.cn.

image

@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Fixes must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 2a50472
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@pahud pahud closed this Mar 21, 2023
@ItielOlenick
Copy link

Still an issue on 2.74.0 (latest python)

@djessup
Copy link

djessup commented May 3, 2023

Ya'll seem to break China like this every few months or so. AWS Partitions are a thing, China and GovCloud are the notable examples. I don't know what the situation is in AWS C2S (aka "spook-cloud"), but probably it's a similar deal. Given how deep-rooted and necessary this concept seems to be, I can't see it going away anytime soon.

Next time somebody has a bright idea to optimise or get rid of region-info somehow - please, just don't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eks: fail to create eks nodegroup in cn-north-1
4 participants