-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(custom-resource): Using NODEJS_18_X with AwsCustomResource #24725
chore(custom-resource): Using NODEJS_18_X with AwsCustomResource #24725
Conversation
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
So unfortunately, we can't accept this as is. There are some regions that Node18 runtimes aren't available yet, notably China and GovCloud. We are working on building something to select the default runtime version based on the current region to address this. Thank you for the contribution though. If you're interested in setting up that region check mechanism, definitely reopen this PR otherwise I'll probably work on something later this week. |
Thanks for replying @MrArnoldPalmer . |
|
Is there any way to revive this PR? China and GovCloud supports Node 18 as of April 12th. https://aws.amazon.com/about-aws/whats-new/2023/04/aws-lambda-node-js-18-govcloud-regions/ |
Thank you @ArielPrevu3D for your comment. I'm working on reopening this PR right now 😉 |
Reopen #25406 |
Details will be given in due course.
Closes #23989.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license