Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(custom-resource): Using NODEJS_18_X with AwsCustomResource #24725

Closed

Conversation

WinterYukky
Copy link
Contributor

Details will be given in due course.

Closes #23989.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added bug This issue is a bug. p2 valued-contributor [Pilot] contributed between 6-12 PRs to the CDK labels Mar 21, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team March 21, 2023 16:58
@WinterYukky WinterYukky changed the title chore(custom-resource): AwsCustomResource to NODEJS_18_X chore(custom-resource): Using NODEJS_18_X with AwsCustomResource Mar 21, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 650c315
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@MrArnoldPalmer
Copy link
Contributor

So unfortunately, we can't accept this as is. There are some regions that Node18 runtimes aren't available yet, notably China and GovCloud. We are working on building something to select the default runtime version based on the current region to address this. Thank you for the contribution though. If you're interested in setting up that region check mechanism, definitely reopen this PR otherwise I'll probably work on something later this week.

@WinterYukky
Copy link
Contributor Author

Thanks for replying @MrArnoldPalmer .
I will gladly accommodate the region check mechanism. However, I can’t reopen this PR (permissions problem?), so I will open new same PR! Thank you.

@mergify
Copy link
Contributor

mergify bot commented Mar 22, 2023

⚠️ The sha of the head commit of this PR conflicts with #24747. Mergify cannot evaluate rules on this PR. ⚠️

@ArielPrevu3D
Copy link

@WinterYukky
Copy link
Contributor Author

Thank you @ArielPrevu3D for your comment. I'm working on reopening this PR right now 😉

@WinterYukky
Copy link
Contributor Author

Reopen #25406

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. p2 valued-contributor [Pilot] contributed between 6-12 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(custom_resources.AwsCustomResource): Upgrade Node 14 to Node 16
4 participants