Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(batch): ephemeralStorage property on job definitions #25399

Merged
merged 31 commits into from
Jun 20, 2023
Merged

feat(batch): ephemeralStorage property on job definitions #25399

merged 31 commits into from
Jun 20, 2023

Commits on May 2, 2023

  1. add ephemeralStorage property and unit test 

    Signed-off-by: Sumu <sumughan@amazon.com>
    @sumupitchayan
    sumupitchayan committed May 2, 2023
    Configuration menu
    Copy the full SHA
    fe9d5ce View commit details
    Browse the repository at this point in the history

  2. add ephemeralStorage in README 

    Signed-off-by: Sumu <sumughan@amazon.com>
    @sumupitchayan
    sumupitchayan committed May 2, 2023
    Configuration menu
    Copy the full SHA
    3854e10 View commit details
    Browse the repository at this point in the history

  3. add new prop to integ test 

    Signed-off-by: Sumu <sumughan@amazon.com>
    @sumupitchayan
    sumupitchayan committed May 2, 2023
    Configuration menu
    Copy the full SHA
    81efde2 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2023

  1. Merge branch 'main' into sumughan/batch-add-ephemeralstorage-prop

    @sumupitchayan
    sumupitchayan committed May 3, 2023
    Configuration menu
    Copy the full SHA
    0ec9174 View commit details
    Browse the repository at this point in the history

  2. add new prop to IEcsContainerDefinition 

    Signed-off-by: Sumu <sumughan@amazon.com>
    @sumupitchayan
    sumupitchayan committed May 3, 2023
    Configuration menu
    Copy the full SHA
    2af1f44 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2023

  1. move ephemeral storage to Fargate class 

    Signed-off-by: Sumu <sumughan@amazon.com>
    @sumupitchayan
    sumupitchayan committed May 4, 2023
    Configuration menu
    Copy the full SHA
    22e06ab View commit details
    Browse the repository at this point in the history

  2. add ephemeralStorage to CloudFormation and fix test format 

    Signed-off-by: Sumu <sumughan@amazon.com>
    @sumupitchayan
    sumupitchayan committed May 4, 2023
    Configuration menu
    Copy the full SHA
    5d51fb2 View commit details
    Browse the repository at this point in the history

  3. update integ test snapshots 

    Signed-off-by: Sumu <sumughan@amazon.com>
    @sumupitchayan
    sumupitchayan committed May 4, 2023
    Configuration menu
    Copy the full SHA
    3d07bd1 View commit details
    Browse the repository at this point in the history

  4. remove README typo 

    Signed-off-by: Sumu <sumughan@amazon.com>
    @sumupitchayan
    sumupitchayan committed May 4, 2023
    Configuration menu
    Copy the full SHA
    1699e71 View commit details
    Browse the repository at this point in the history

  5. remove test comments 

    Signed-off-by: Sumu <sumughan@amazon.com>
    @sumupitchayan
    sumupitchayan committed May 4, 2023
    Configuration menu
    Copy the full SHA
    c023e0e View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into sumughan/batch-add-ephemeralstorage-prop

    @sumupitchayan
    sumupitchayan committed May 4, 2023
    Configuration menu
    Copy the full SHA
    b71a742 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2023

  1. Merge branch 'main' into sumughan/batch-add-ephemeralstorage-prop

    @sumupitchayan
    sumupitchayan committed May 5, 2023
    Configuration menu
    Copy the full SHA
    f95a4c8 View commit details
    Browse the repository at this point in the history

  2. Update packages/@aws-cdk/aws-batch-alpha/lib/ecs-container-definition.ts 

    Co-authored-by: Calvin Combs <66279577+comcalvi@users.noreply.github.com>
    @sumupitchayan @comcalvi
    sumupitchayan and comcalvi committed May 5, 2023
    Configuration menu
    Copy the full SHA
    84c5040 View commit details
    Browse the repository at this point in the history

  3. Update packages/@aws-cdk/aws-batch-alpha/lib/ecs-container-definition.ts 

    Co-authored-by: Calvin Combs <66279577+comcalvi@users.noreply.github.com>
    @sumupitchayan @comcalvi
    sumupitchayan and comcalvi committed May 5, 2023
    Configuration menu
    Copy the full SHA
    2719d0c View commit details
    Browse the repository at this point in the history

  4. Update packages/@aws-cdk/aws-batch-alpha/test/ecs-container-definitio… 

    …n.test.ts

Co-authored-by: Calvin Combs <66279577+comcalvi@users.noreply.github.com>
    @sumupitchayan @comcalvi
    sumupitchayan and comcalvi committed May 5, 2023
    Configuration menu
    Copy the full SHA
    cdc7006 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2023

  1. rename to ephemeralStorageSize 

    Signed-off-by: Sumu <sumughan@amazon.com>
    @sumupitchayan
    sumupitchayan committed May 8, 2023
    Configuration menu
    Copy the full SHA
    bdfb89a View commit details
    Browse the repository at this point in the history

  2. finish renaming to ephemeralStorageSize 

    Signed-off-by: Sumu <sumughan@amazon.com>
    @sumupitchayan
    sumupitchayan committed May 8, 2023
    Configuration menu
    Copy the full SHA
    03b220c View commit details
    Browse the repository at this point in the history

  3. add validation and unit test 

    Signed-off-by: Sumu <sumughan@amazon.com>
    @sumupitchayan
    sumupitchayan committed May 8, 2023
    Configuration menu
    Copy the full SHA
    8218d4c View commit details
    Browse the repository at this point in the history

  4. make prop undefined by default 

    Signed-off-by: Sumu <sumughan@amazon.com>
    @sumupitchayan
    sumupitchayan committed May 8, 2023
    Configuration menu
    Copy the full SHA
    58b2ce5 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2023

  1. refactor code for breaking change, moving executionRole property to E… 

    …csContainerDefinitionProps only

Signed-off-by: Sumu <sumughan@amazon.com>
    @sumupitchayan
    sumupitchayan committed May 9, 2023
    Configuration menu
    Copy the full SHA
    c8023c3 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into sumughan/batch-add-ephemeralstorage-prop

    @sumupitchayan
    sumupitchayan committed May 9, 2023
    Configuration menu
    Copy the full SHA
    c2e5e1d View commit details
    Browse the repository at this point in the history

  3. Kaizen suggestion - writing 20 GiB for default 

    Signed-off-by: Sumu <sumughan@amazon.com>
    @sumupitchayan
    sumupitchayan committed May 9, 2023
    Configuration menu
    Copy the full SHA
    d341a1f View commit details
    Browse the repository at this point in the history

  4. kaizen suggestion: simplify test case and use throw error('') instead… 

    … of node.addValidation

Signed-off-by: Sumu <sumughan@amazon.com>
    @sumupitchayan
    sumupitchayan committed May 9, 2023
    Configuration menu
    Copy the full SHA
    06e4dab View commit details
    Browse the repository at this point in the history

  5. add test adding ephemeralStorage as a Token 

    Signed-off-by: Sumu <sumughan@amazon.com>
    @sumupitchayan
    sumupitchayan committed May 9, 2023
    Configuration menu
    Copy the full SHA
    d36b2b3 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into sumughan/batch-add-ephemeralstorage-prop

    @sumupitchayan
    sumupitchayan committed May 9, 2023
    Configuration menu
    Copy the full SHA
    06529b6 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2023

  1. fix calvin formatting suggestions 

    Signed-off-by: Sumu <sumughan@amazon.com>
    @sumupitchayan
    sumupitchayan committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    72ace6e View commit details
    Browse the repository at this point in the history

  2. Update packages/@aws-cdk/aws-batch-alpha/lib/ecs-container-definition.ts 

    Co-authored-by: Calvin Combs <66279577+comcalvi@users.noreply.github.com>
    @sumupitchayan @comcalvi
    sumupitchayan and comcalvi committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    62728cd View commit details
    Browse the repository at this point in the history

  3. Update packages/@aws-cdk/aws-batch-alpha/lib/ecs-container-definition.ts 

    Co-authored-by: Calvin Combs <66279577+comcalvi@users.noreply.github.com>
    @sumupitchayan @comcalvi
    sumupitchayan and comcalvi committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    b0c672b View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2023

  1. fix build failure by adding quotes within error expected error msg 

    Signed-off-by: Sumu <sumughan@amazon.com>
    @sumupitchayan
    sumupitchayan committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    ef9727d View commit details
    Browse the repository at this point in the history

  2. kaizen suggestion, remove creating new app in unit test 

    Signed-off-by: Sumu <sumughan@amazon.com>
    @sumupitchayan
    sumupitchayan committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    b025fbd View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into sumughan/batch-add-ephemeralstorage-prop

    @mergify
    mergify[bot] committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    97fded2 View commit details
    Browse the repository at this point in the history