Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update nodejs to 18 in gitpod #25426

Merged
merged 5 commits into from
May 21, 2023
Merged

Conversation

watany-dev
Copy link
Contributor

I love using Gitpod! I saw that node18 support is needed at #25381 and understood the situation.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented May 4, 2023

@github-actions github-actions bot added the p2 label May 4, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team May 4, 2023 01:40
@github-actions github-actions bot added the star-contributor [Pilot] contributed between 25-49 PRs to the CDK label May 4, 2023
@pahud
Copy link
Contributor

pahud commented May 4, 2023

Just opened your PR branch and the prebuild with node18 was doing great.

It's not mandatory to opt in 18 but now that we have a PR here I don't see any reason not 😄.

image

.gitpod.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@pahud pahud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use ecr public.

Co-authored-by: Pahud Hsieh <pahudnet@gmail.com>
@watany-dev
Copy link
Contributor Author

Thank you for your review. Certainly this should be obtained from ECR Public!

@watany-dev watany-dev requested a review from pahud May 5, 2023 10:00
@corymhall corymhall added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 8, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 16ac095
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented May 21, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 48a4524 into aws:main May 21, 2023
@watany-dev watany-dev deleted the upgrade-gitpod-image branch May 21, 2023 11:33
mergify bot pushed a commit that referenced this pull request Jun 4, 2024
### Reason for this change

The contribution guide recommend the active node LTS: https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md#getting-started

### Description of changes

Update node 18 to 20 in devcontainer and gitpod and also the os version to bookworm

### Description of how you validated changes

opened devcontainer and gitpod,  checkd the node version and run command `npx lerna run build --scope=aws-cdk-lib --scope=@aws-cdk-testing/framework-integ --skip-nx-cache`

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

refs:

- #25381
- #25426

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
vdahlberg pushed a commit to vdahlberg/aws-cdk that referenced this pull request Jun 10, 2024
### Reason for this change

The contribution guide recommend the active node LTS: https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md#getting-started

### Description of changes

Update node 18 to 20 in devcontainer and gitpod and also the os version to bookworm

### Description of how you validated changes

opened devcontainer and gitpod,  checkd the node version and run command `npx lerna run build --scope=aws-cdk-lib --scope=@aws-cdk-testing/framework-integ --skip-nx-cache`

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

refs:

- aws#25381
- aws#25426

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Leo10Gama pushed a commit to Leo10Gama/aws-cdk that referenced this pull request Jun 11, 2024
### Reason for this change

The contribution guide recommend the active node LTS: https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md#getting-started

### Description of changes

Update node 18 to 20 in devcontainer and gitpod and also the os version to bookworm

### Description of how you validated changes

opened devcontainer and gitpod,  checkd the node version and run command `npx lerna run build --scope=aws-cdk-lib --scope=@aws-cdk-testing/framework-integ --skip-nx-cache`

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

refs:

- aws#25381
- aws#25426

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
mazyu36 pushed a commit to mazyu36/aws-cdk that referenced this pull request Jun 22, 2024
### Reason for this change

The contribution guide recommend the active node LTS: https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md#getting-started

### Description of changes

Update node 18 to 20 in devcontainer and gitpod and also the os version to bookworm

### Description of how you validated changes

opened devcontainer and gitpod,  checkd the node version and run command `npx lerna run build --scope=aws-cdk-lib --scope=@aws-cdk-testing/framework-integ --skip-nx-cache`

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

refs:

- aws#25381
- aws#25426

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. star-contributor [Pilot] contributed between 25-49 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants