Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ecs): unclear docs on valid ec2 task definition placement constraints and no validation of input #25933

Closed
wants to merge 21 commits into from
Closed

fix(ecs): unclear docs on valid ec2 task definition placement constraints and no validation of input #25933

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
3165fa5
fix: added placement constraints validation for EC2 task definitions …
Adibuer-lab Jun 11, 2023
6468b24
remove empty redundant file integ.ec2-task-definition.ts(aws#25905)
Adibuer-lab Jun 11, 2023
bfe3612
Merge branch 'main' into fix/25905-ecs-placement-constraints
Adibuer-lab Jun 12, 2023
4c65f56
Merge branch 'main' into fix/25905-ecs-placement-constraints
Adibuer-lab Jun 12, 2023
e455cb6
test
Adibuer-lab Jun 12, 2023
1d80192
Merge branch 'main' into fix/25905-ecs-placement-constraints
Adibuer-lab Jun 12, 2023
000d970
Merge branch 'main' into fix/25905-ecs-placement-constraints
Adibuer-lab Jun 20, 2023
000e2eb
Merge branch 'main' into fix/25905-ecs-placement-constraints
Adibuer-lab Jun 28, 2023
93627ca
Update packages/aws-cdk-lib/aws-ecs/lib/ec2/ec2-task-definition.ts
Adibuer-lab Jul 16, 2023
78b231f
Merge branch 'aws:main' into fix/25905-ecs-placement-constraints
Adibuer-lab Jul 16, 2023
47909de
Update packages/aws-cdk-lib/aws-ecs/lib/ec2/ec2-task-definition.ts
Adibuer-lab Jul 16, 2023
007c834
Update packages/aws-cdk-lib/aws-ecs/lib/ec2/ec2-task-definition.ts
Adibuer-lab Jul 16, 2023
2c8f67d
Update packages/aws-cdk-lib/aws-ecs/lib/ec2/ec2-task-definition.ts
Adibuer-lab Jul 16, 2023
654daa8
Update packages/aws-cdk-lib/aws-ecs/lib/ec2/ec2-task-definition.ts
Adibuer-lab Jul 16, 2023
b4f3ac0
Update packages/aws-cdk-lib/aws-ecs/lib/ec2/ec2-task-definition.ts
Adibuer-lab Jul 16, 2023
a03b585
Update packages/aws-cdk-lib/aws-ecs/lib/ec2/ec2-task-definition.ts
Adibuer-lab Jul 16, 2023
c43f4a5
Update packages/aws-cdk-lib/aws-ecs/lib/ec2/ec2-task-definition.ts
Adibuer-lab Jul 16, 2023
8cc5703
Update packages/aws-cdk-lib/aws-ecs/lib/ec2/ec2-task-definition.ts
Adibuer-lab Jul 16, 2023
254dbbb
error msg should report back invalid constraint
Adibuer-lab Jul 16, 2023
77b5f8b
remove yarn.lock
Adibuer-lab Jul 16, 2023
66f24b1
25933
Adibuer-lab Jul 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
147 changes: 147 additions & 0 deletions .../asset.ba598c1f1d84f7077ea9c16a6b921e4f8acf18e996100e72a8f17da980e64fdd/__entrypoint__.js
View file
Open in desktop

Large diffs are not rendered by default.

81 changes: 81 additions & 0 deletions ....snapshot/asset.ba598c1f1d84f7077ea9c16a6b921e4f8acf18e996100e72a8f17da980e64fdd/index.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

32 changes: 32 additions & 0 deletions ...finition-placement-constraints.js.snapshot/aws-cdk-ecs-integration-test-stack.assets.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
{
"version": "32.0.0",
"files": {
"ba598c1f1d84f7077ea9c16a6b921e4f8acf18e996100e72a8f17da980e64fdd": {
"source": {
"path": "asset.ba598c1f1d84f7077ea9c16a6b921e4f8acf18e996100e72a8f17da980e64fdd",
"packaging": "zip"
},
"destinations": {
"current_account-current_region": {
"bucketName": "cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}",
"objectKey": "ba598c1f1d84f7077ea9c16a6b921e4f8acf18e996100e72a8f17da980e64fdd.zip",
"assumeRoleArn": "arn:${AWS::Partition}:iam::${AWS::AccountId}:role/cdk-hnb659fds-file-publishing-role-${AWS::AccountId}-${AWS::Region}"
}
}
},
"0a9ca3828434fca52688d82a6c9438b44fc25f418219dcc41eefa938e401e99b": {
"source": {
"path": "aws-cdk-ecs-integration-test-stack.template.json",
"packaging": "file"
},
"destinations": {
"current_account-current_region": {
"bucketName": "cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}",
"objectKey": "0a9ca3828434fca52688d82a6c9438b44fc25f418219dcc41eefa938e401e99b.json",
"assumeRoleArn": "arn:${AWS::Partition}:iam::${AWS::AccountId}:role/cdk-hnb659fds-file-publishing-role-${AWS::AccountId}-${AWS::Region}"
}
}
}
},
"dockerImages": {}
}
Loading