Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): acknowledge warnings #26144

Merged
merged 35 commits into from
Aug 23, 2023
Merged

feat(core): acknowledge warnings #26144

merged 35 commits into from
Aug 23, 2023

Commits on Jun 28, 2023

  1. feat(core): acknowledge annotation warning messages

    This PR adds the ability to acknowledge annotation warning messages.
    I've updated some of the annotations in the `rds.Cluster` construct to
    show how this will work. After this is merged we can work on adding the
    ids to all of the warning messages throughout the construct library.
    
    The main motivation behind this is to allow people to set the `--strict`
    mode to fail synthesis on warnings. Currently it is all or nothing, you
    have to get rid of _all_ warnings to use `--strict`. With this feature
    users will be able to `acknowledge` warnings saying that they are aware,
    but it does not apply to them.
    
    Since we want all warnings to now have an id this will deprecate the
    `addWarning` method and adds a new `addWarningV2` method.
    
    Since the acknowledgements and warnings are written as metadata, it is
    possible to enhance this in the future to report on warnings and
    acknowledgements.
    corymhall committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    5ce3b70 View commit details
    Browse the repository at this point in the history
  2. adding deprecation

    corymhall committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    fca3a1a View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2023

  1. Configuration menu
    Copy the full SHA
    707be7f View commit details
    Browse the repository at this point in the history
  2. updated readme

    corymhall committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    5229dc9 View commit details
    Browse the repository at this point in the history
  3. fixing lint errors

    corymhall committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    bb217e3 View commit details
    Browse the repository at this point in the history
  4. fixing tests

    corymhall committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    9e19207 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a9f506e View commit details
    Browse the repository at this point in the history
  6. adding to breaking change

    corymhall committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    4b8ad28 View commit details
    Browse the repository at this point in the history
  7. couple more

    corymhall committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    eb244d8 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2023

  1. adding examples

    corymhall committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    54a2910 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2023

  1. adding adr

    corymhall committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    06f8559 View commit details
    Browse the repository at this point in the history
  2. formatting the messages

    corymhall committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    4af1135 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2023

  1. Configuration menu
    Copy the full SHA
    9198add View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    957c238 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f0ce23b View commit details
    Browse the repository at this point in the history
  4. Comment

    rix0rrr committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    6412029 View commit details
    Browse the repository at this point in the history
  5. Update adr

    rix0rrr committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    df8a853 View commit details
    Browse the repository at this point in the history
  6. Undo test change

    rix0rrr committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    5aba9ac View commit details
    Browse the repository at this point in the history
  7. addWarning -> addWarningV2

    rix0rrr committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    ee9fc76 View commit details
    Browse the repository at this point in the history
  8. Linterrrr

    rix0rrr committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    56625ac View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2023

  1. Update tests

    rix0rrr committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    cd72788 View commit details
    Browse the repository at this point in the history
  2. More tests

    rix0rrr committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    87b3b12 View commit details
    Browse the repository at this point in the history
  3. Oops

    rix0rrr committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    c0b5319 View commit details
    Browse the repository at this point in the history
  4. Test again

    rix0rrr committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    a95dde9 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    acca007 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2023

  1. Foutje

    rix0rrr committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    da5211d View commit details
    Browse the repository at this point in the history
  2. Merge branch 'corymhall/core/ack-warnings' of github.com:corymhall/aw…

    …s-cdk into pr/corymhall/26144
    rix0rrr committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    9e9a6fd View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    52ecb54 View commit details
    Browse the repository at this point in the history
  4. Merge branch 'corymhall/core/ack-warnings' of github.com:corymhall/aw…

    …s-cdk into pr/corymhall/26144
    rix0rrr committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    7c5b1c7 View commit details
    Browse the repository at this point in the history
  5. This is not a warning

    rix0rrr committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    4fb2770 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2023

  1. Configuration menu
    Copy the full SHA
    af14a3f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    696945d View commit details
    Browse the repository at this point in the history
  3. Fix examples

    rix0rrr committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    6361023 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    52eab30 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e8d78d6 View commit details
    Browse the repository at this point in the history