-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): acknowledge warnings #26144
Merged
Merged
Commits on Jun 28, 2023
-
feat(core): acknowledge annotation warning messages
This PR adds the ability to acknowledge annotation warning messages. I've updated some of the annotations in the `rds.Cluster` construct to show how this will work. After this is merged we can work on adding the ids to all of the warning messages throughout the construct library. The main motivation behind this is to allow people to set the `--strict` mode to fail synthesis on warnings. Currently it is all or nothing, you have to get rid of _all_ warnings to use `--strict`. With this feature users will be able to `acknowledge` warnings saying that they are aware, but it does not apply to them. Since we want all warnings to now have an id this will deprecate the `addWarning` method and adds a new `addWarningV2` method. Since the acknowledgements and warnings are written as metadata, it is possible to enhance this in the future to report on warnings and acknowledgements.
Configuration menu - View commit details
-
Copy full SHA for 5ce3b70 - Browse repository at this point
Copy the full SHA 5ce3b70View commit details -
Configuration menu - View commit details
-
Copy full SHA for fca3a1a - Browse repository at this point
Copy the full SHA fca3a1aView commit details
Commits on Jun 29, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 707be7f - Browse repository at this point
Copy the full SHA 707be7fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5229dc9 - Browse repository at this point
Copy the full SHA 5229dc9View commit details -
Configuration menu - View commit details
-
Copy full SHA for bb217e3 - Browse repository at this point
Copy the full SHA bb217e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e19207 - Browse repository at this point
Copy the full SHA 9e19207View commit details -
Configuration menu - View commit details
-
Copy full SHA for a9f506e - Browse repository at this point
Copy the full SHA a9f506eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4b8ad28 - Browse repository at this point
Copy the full SHA 4b8ad28View commit details -
Configuration menu - View commit details
-
Copy full SHA for eb244d8 - Browse repository at this point
Copy the full SHA eb244d8View commit details
Commits on Jun 30, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 54a2910 - Browse repository at this point
Copy the full SHA 54a2910View commit details
Commits on Jul 5, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 06f8559 - Browse repository at this point
Copy the full SHA 06f8559View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4af1135 - Browse repository at this point
Copy the full SHA 4af1135View commit details
Commits on Aug 18, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 9198add - Browse repository at this point
Copy the full SHA 9198addView commit details -
Configuration menu - View commit details
-
Copy full SHA for 957c238 - Browse repository at this point
Copy the full SHA 957c238View commit details -
Configuration menu - View commit details
-
Copy full SHA for f0ce23b - Browse repository at this point
Copy the full SHA f0ce23bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6412029 - Browse repository at this point
Copy the full SHA 6412029View commit details -
Configuration menu - View commit details
-
Copy full SHA for df8a853 - Browse repository at this point
Copy the full SHA df8a853View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5aba9ac - Browse repository at this point
Copy the full SHA 5aba9acView commit details -
Configuration menu - View commit details
-
Copy full SHA for ee9fc76 - Browse repository at this point
Copy the full SHA ee9fc76View commit details -
Configuration menu - View commit details
-
Copy full SHA for 56625ac - Browse repository at this point
Copy the full SHA 56625acView commit details
Commits on Aug 21, 2023
-
Configuration menu - View commit details
-
Copy full SHA for cd72788 - Browse repository at this point
Copy the full SHA cd72788View commit details -
Configuration menu - View commit details
-
Copy full SHA for 87b3b12 - Browse repository at this point
Copy the full SHA 87b3b12View commit details -
Configuration menu - View commit details
-
Copy full SHA for c0b5319 - Browse repository at this point
Copy the full SHA c0b5319View commit details -
Configuration menu - View commit details
-
Copy full SHA for a95dde9 - Browse repository at this point
Copy the full SHA a95dde9View commit details -
Configuration menu - View commit details
-
Copy full SHA for acca007 - Browse repository at this point
Copy the full SHA acca007View commit details
Commits on Aug 22, 2023
-
Configuration menu - View commit details
-
Copy full SHA for da5211d - Browse repository at this point
Copy the full SHA da5211dView commit details -
Merge branch 'corymhall/core/ack-warnings' of github.com:corymhall/aw…
…s-cdk into pr/corymhall/26144
Configuration menu - View commit details
-
Copy full SHA for 9e9a6fd - Browse repository at this point
Copy the full SHA 9e9a6fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 52ecb54 - Browse repository at this point
Copy the full SHA 52ecb54View commit details -
Merge branch 'corymhall/core/ack-warnings' of github.com:corymhall/aw…
…s-cdk into pr/corymhall/26144
Configuration menu - View commit details
-
Copy full SHA for 7c5b1c7 - Browse repository at this point
Copy the full SHA 7c5b1c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4fb2770 - Browse repository at this point
Copy the full SHA 4fb2770View commit details
Commits on Aug 23, 2023
-
Configuration menu - View commit details
-
Copy full SHA for af14a3f - Browse repository at this point
Copy the full SHA af14a3fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 696945d - Browse repository at this point
Copy the full SHA 696945dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6361023 - Browse repository at this point
Copy the full SHA 6361023View commit details -
Configuration menu - View commit details
-
Copy full SHA for 52eab30 - Browse repository at this point
Copy the full SHA 52eab30View commit details -
Configuration menu - View commit details
-
Copy full SHA for e8d78d6 - Browse repository at this point
Copy the full SHA e8d78d6View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.