Handle return from yargs command modules #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent the application from reaching the code path in `main` when the command was handled directly by a `commandDir` module. This prevents the operation from succeeding, while displaying a message such as *"Unknown command: docs"* (#256). In order to achieve this, the module decorator sets `argv.result` on successful execution of the command module's handler; and if `argv.result` is set, `main` does not get called. Fixes #256
eladb
approved these changes
Jul 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent the application from reaching the code path in
mainwhen thecommand was handled directly by a
commandDirmodule. This preventsthe operation from succeeding, while displaying a message such as
"Unknown command: docs" (#256).
In order to achieve this, the module decorator sets
argv.resultonsuccessful execution of the command module's handler; and if
argv.resultis set,maindoes not get called.Fixes #256