Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(cloudwatch): document cross-account/cross-region alarm limitations #26204

Merged
merged 2 commits into from
Jul 3, 2023
Merged

docs(cloudwatch): document cross-account/cross-region alarm limitations #26204

merged 2 commits into from
Jul 3, 2023

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Jul 3, 2023

This is in response to an internal ticket where someone indicated that their 2 datapoints cross-account Alarm was not working.

AWS Support responded with the above reasoning.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@rix0rrr
docs(cloudwatch): document cross-account/cross-region alarm limitations
86dc32d 
This is in response to an internal ticket where someone indicated
that their 2 datapoints cross-account Alarm was not working.

AWS Support responded with the above reasoning.
@rix0rrr rix0rrr requested a review from a team July 3, 2023 12:58
@gitpod-io
Copy link

gitpod-io bot commented Jul 3, 2023

@github-actions github-actions bot added the p2 label Jul 3, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jul 3, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 3, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 3, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 594b280
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit bed1ebe into main Jul 3, 2023
@mergify mergify bot deleted the huijbers/document-alarm-limitations branch July 3, 2023 14:38
@mergify
Copy link
Contributor

mergify bot commented Jul 3, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

kaizencc added a commit that referenced this pull request Jul 5, 2023
@kaizencc
Revert "docs(cloudwatch): document cross-account/cross-region alarm l…
e650a3f 
…imitations (#26204)"

This reverts commit bed1ebe.
@kaizencc kaizencc mentioned this pull request Jul 5, 2023
Merged
mergify bot pushed a commit that referenced this pull request Jul 6, 2023
@kaizencc
chore: revert "docs(cloudwatch): document cross-account/cross-region …
212b81b 
…alarm limitations" (#26246)

Reverts #26204

The documentation that cross-account alarms with `evaluationPeriods > 1` is incorrect, or at least too strict. I was able to create an alarm in Account B that references a metric in Account A with evaluationPeriod = 2.
@kaizencc kaizencc mentioned this pull request Jul 6, 2023
Merged
tmokmss pushed a commit to tmokmss/aws-cdk that referenced this pull request Jul 9, 2023
@kaizencc @tmokmss
chore: revert "docs(cloudwatch): document cross-account/cross-region …
9247a59 
…alarm limitations" (aws#26246)

Reverts aws#26204

The documentation that cross-account alarms with `evaluationPeriods > 1` is incorrect, or at least too strict. I was able to create an alarm in Account B that references a metric in Account A with evaluationPeriod = 2.
mergify bot pushed a commit that referenced this pull request Jul 10, 2023
@kaizencc
docs(cloudwatch): document cross-account/cross-region alarm limitatio…
1e33586 
…ns (#26269)

Reroll of #26204, that was reverted.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
bmoffatt pushed a commit to bmoffatt/aws-cdk that referenced this pull request Jul 29, 2023
@kaizencc @bmoffatt
chore: revert "docs(cloudwatch): document cross-account/cross-region …
4eacc1b 
…alarm limitations" (aws#26246)

Reverts aws#26204

The documentation that cross-account alarms with `evaluationPeriods > 1` is incorrect, or at least too strict. I was able to create an alarm in Account B that references a metric in Account A with evaluationPeriod = 2.
bmoffatt pushed a commit to bmoffatt/aws-cdk that referenced this pull request Jul 29, 2023
@kaizencc @bmoffatt
docs(cloudwatch): document cross-account/cross-region alarm limitatio…
dc795d6 
…ns (aws#26269)

Reroll of aws#26204, that was reverted.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions github-actions bot mentioned this pull request Aug 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrgrain mrgrain mrgrain approved these changes

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS. p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rix0rrr @aws-cdk-automation @mrgrain