Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: latest lerna doesn't work anymore with repo #26279

Merged
merged 2 commits into from
Jul 7, 2023

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Jul 7, 2023

On the v1-main branch, we install the latest lerna when we're trying to do a version bump. Just use the lerna from package.json instead. The newest one gives this error:

lerna notice cli v7.1.1
lerna ERR! ECONFIGWORKSPACES The "useWorkspaces" option has been removed. By default lerna will resolve your packages using your package manager's workspaces configuration. Alternatively, you can manually provide a list of package globs to be used instead via the "packages" option in lerna.json.

I need a final successful run of this workflow, because otherwise our GitHub Workflow monitoring infrastructure will endlessly create tickets for the final run it sees, which is failing.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

On the `v1-main` branch, we install the latest `lerna` when we're
trying to do a version bump. Just use the `lerna` from `package.json`
instead. The newest one gives this error:

```
lerna notice cli v7.1.1
lerna ERR! ECONFIGWORKSPACES The "useWorkspaces" option has been removed. By default lerna will resolve your packages using your package manager's workspaces configuration. Alternatively, you can manually provide a list of package globs to be used instead via the "packages" option in lerna.json.
```

I need a final successful run of this workflow, because otherwise
our GitHub Workflow monitoring infrastructure will endlessly create
tickets for the final run it sees, which is failing.
@rix0rrr rix0rrr requested a review from a team July 7, 2023 10:03
@gitpod-io
Copy link

gitpod-io bot commented Jul 7, 2023

@github-actions github-actions bot added the p2 label Jul 7, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team July 7, 2023 10:03
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jul 7, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 7, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: cca374a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit d34e7c9 into main Jul 7, 2023
@mergify mergify bot deleted the huijbers/dont-install-lerna branch July 7, 2023 10:58
@mergify
Copy link
Contributor

mergify bot commented Jul 7, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

tmokmss pushed a commit to tmokmss/aws-cdk that referenced this pull request Jul 9, 2023
On the `v1-main` branch, we install the latest `lerna` when we're trying to do a version bump. Just use the `lerna` from `package.json` instead. The newest one gives this error:

```
lerna notice cli v7.1.1
lerna ERR! ECONFIGWORKSPACES The "useWorkspaces" option has been removed. By default lerna will resolve your packages using your package manager's workspaces configuration. Alternatively, you can manually provide a list of package globs to be used instead via the "packages" option in lerna.json.
```

I need a final successful run of this workflow, because otherwise our GitHub Workflow monitoring infrastructure will endlessly create tickets for the final run it sees, which is failing.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
bmoffatt pushed a commit to bmoffatt/aws-cdk that referenced this pull request Jul 29, 2023
On the `v1-main` branch, we install the latest `lerna` when we're trying to do a version bump. Just use the `lerna` from `package.json` instead. The newest one gives this error:

```
lerna notice cli v7.1.1
lerna ERR! ECONFIGWORKSPACES The "useWorkspaces" option has been removed. By default lerna will resolve your packages using your package manager's workspaces configuration. Alternatively, you can manually provide a list of package globs to be used instead via the "packages" option in lerna.json.
```

I need a final successful run of this workflow, because otherwise our GitHub Workflow monitoring infrastructure will endlessly create tickets for the final run it sees, which is failing.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants