Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rds): support configuring secret rotation behavior via rotateImmediatelyOnUpdate prop #26329

Merged
merged 37 commits into from
Jul 18, 2023
Merged

feat(rds): support configuring secret rotation behavior via rotateImmediatelyOnUpdate prop #26329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
bac3908
exposed rotateImmediatelyOnUpdate prop on SecretRotationProps and Com…
colifran Jul 11, 2023
30d8a9a
added unit tests for rotateImmediatelyOnUpdate for single and multi u…
colifran Jul 12, 2023
6f590cb
updated unit test naming
colifran Jul 12, 2023
10036e6
removed deprecated cluster instanceProps in unit tests
colifran Jul 12, 2023
86c550f
updated cluster rotation integ test with rotateImmediatelyOnUpdate as…
colifran Jul 12, 2023
59e9330
snapshots for cluster rotation integ test
colifran Jul 12, 2023
49cec8f
README updates
colifran Jul 12, 2023
d55a9f9
made @default true for rotateImmediatelyOnUpdate
colifran Jul 12, 2023
3f55fe2
README update
colifran Jul 12, 2023
2eaa769
Merge branch 'main' into colifran/rotate-immediately-on-update
colifran Jul 12, 2023
5ac416a
README updates
colifran Jul 12, 2023
a7aeb33
unit test updates
colifran Jul 12, 2023
36eb99a
unit test correction
colifran Jul 12, 2023
d8c1ee9
README formatting
colifran Jul 12, 2023
8928b9d
Merge branch 'main' into colifran/rotate-immediately-on-update
colifran Jul 12, 2023
0eb2064
chore(app-staging-synthesizer): document and test `autoDeleteStagingA…
kaizencc Jul 12, 2023
448c452
feat(aws-cdk-lib): use new L1 codegen (#26318)
mrgrain Jul 13, 2023
e6fa65c
chore(deps): remove v1 upgrades (#26347)
iliapolo Jul 13, 2023
c56fd52
docs(cfnspec): update CloudFormation documentation (#26301)
aws-cdk-automation Jul 13, 2023
a290d3b
feat(iot-actions): iot rule https action l2 construct (#25535)
cponfick Jul 13, 2023
a53cabd
chore: fix example compilation issues (#26331)
kaizencc Jul 13, 2023
f25738d
docs(cfnspec): update CloudFormation documentation (#26361)
aws-cdk-automation Jul 14, 2023
63c3b8d
feat(cfnspec): cloudformation spec v130.1.0 (#26362)
aws-cdk-automation Jul 14, 2023
078e8d8
chore(core): augmentations should use relative import (#26364)
mrgrain Jul 14, 2023
c0d8c22
fix(aws_ecs): Do not output NetworkConfiguraiton to ECS Service when …
msysh Jul 14, 2023
28b433c
docs(core): docs for fingerprint are incorrect (#26353)
go-to-k Jul 14, 2023
ae80ed4
feat(core): allow user to specify --platform (#26368)
maafk Jul 14, 2023
e53cefe
feat(lambda-event-sources): added filters support to kafka sources (#…
lpizzinidev Jul 14, 2023
761cf40
chore(cdk-lib): re-enable skipped tests (#26367)
mrgrain Jul 16, 2023
1b4725a
fix(lambda): bundling fails with pnpm >= 8.4.0 (#25612) (#26386)
damienhill Jul 17, 2023
88b6a24
chore: dont npm ignore custom resource handlers (#26379)
iliapolo Jul 17, 2023
04c8e39
feat(rds): support aurora postgresql 15.3 (#26377)
WinterYukky Jul 17, 2023
f93ee1f
chore(lambda): add toString to lambda architecture (#26145)
lukey-aleios Jul 17, 2023
db6c839
fix(s3): allow empty string as keyPrefixEquals (#26243)
dbartholomae Jul 17, 2023
488e05d
updated README
colifran Jul 17, 2023
367b36e
Merge branch 'main' into colifran/rotate-immediately-on-update
colifran Jul 17, 2023
d0e23fe
Merge branch 'main' into colifran/rotate-immediately-on-update
mergify[bot] Jul 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...-rds/test/integ.cluster-rotation.lit.js.snapshot/aws-cdk-rds-cluster-rotation.assets.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
{
"version": "31.0.0",
"version": "32.0.0",
"files": {
"a633d33a056f9a9a775353c3902b2da4fa8318b43707e565b45a591da0888305": {
"c62036466c88b9e1cc7a3ba34aa9d9be5ec760159fac241679198e1e98655fea": {
"source": {
"path": "aws-cdk-rds-cluster-rotation.template.json",
"packaging": "file"
},
"destinations": {
"current_account-current_region": {
"bucketName": "cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}",
"objectKey": "a633d33a056f9a9a775353c3902b2da4fa8318b43707e565b45a591da0888305.json",
"objectKey": "c62036466c88b9e1cc7a3ba34aa9d9be5ec760159fac241679198e1e98655fea.json",
"assumeRoleArn": "arn:${AWS::Partition}:iam::${AWS::AccountId}:role/cdk-hnb659fds-file-publishing-role-${AWS::AccountId}-${AWS::Region}"
}
}
Expand Down
1 change: 1 addition & 0 deletions ...ds/test/integ.cluster-rotation.lit.js.snapshot/aws-cdk-rds-cluster-rotation.template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -915,6 +915,7 @@
"SecretId": {
"Ref": "CustomRotationOptionsSecretAttachment697A23BF"
},
"RotateImmediatelyOnUpdate": false,
"RotationLambdaARN": {
"Fn::GetAtt": [
"CustomRotationOptionsRotationSingleUserC555446F",
Expand Down
2 changes: 1 addition & 1 deletion ...-testing/framework-integ/test/aws-rds/test/integ.cluster-rotation.lit.js.snapshot/cdk.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"version":"31.0.0"}
{"version":"32.0.0"}
2 changes: 1 addition & 1 deletion ...sting/framework-integ/test/aws-rds/test/integ.cluster-rotation.lit.js.snapshot/integ.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"version": "31.0.0",
"version": "32.0.0",
"testCases": {
"integ.cluster-rotation.lit": {
"stacks": [
Expand Down
34 changes: 8 additions & 26 deletions ...ng/framework-integ/test/aws-rds/test/integ.cluster-rotation.lit.js.snapshot/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"version": "31.0.0",
"version": "32.0.0",
"artifacts": {
"aws-cdk-rds-cluster-rotation.assets": {
"type": "cdk:asset-manifest",
Expand All @@ -17,7 +17,7 @@
"validateOnSynth": false,
"assumeRoleArn": "arn:${AWS::Partition}:iam::${AWS::AccountId}:role/cdk-hnb659fds-deploy-role-${AWS::AccountId}-${AWS::Region}",
"cloudFormationExecutionRoleArn": "arn:${AWS::Partition}:iam::${AWS::AccountId}:role/cdk-hnb659fds-cfn-exec-role-${AWS::AccountId}-${AWS::Region}",
"stackTemplateAssetObjectUrl": "s3://cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}/a633d33a056f9a9a775353c3902b2da4fa8318b43707e565b45a591da0888305.json",
"stackTemplateAssetObjectUrl": "s3://cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}/c62036466c88b9e1cc7a3ba34aa9d9be5ec760159fac241679198e1e98655fea.json",
"requiresBootstrapStackVersion": 6,
"bootstrapStackVersionSsmParameter": "/cdk-bootstrap/hnb659fds/version",
"additionalDependencies": [
Expand Down Expand Up @@ -234,28 +234,19 @@
"/aws-cdk-rds-cluster-rotation/Database/Resource": [
{
"type": "aws:cdk:logicalId",
"data": "DatabaseB269D8BB",
"trace": [
"!!DESTRUCTIVE_CHANGES: MAY_REPLACE"
]
"data": "DatabaseB269D8BB"
}
],
"/aws-cdk-rds-cluster-rotation/Database/Instance1": [
{
"type": "aws:cdk:logicalId",
"data": "DatabaseInstance1844F58FD",
"trace": [
"!!DESTRUCTIVE_CHANGES: MAY_REPLACE"
]
"data": "DatabaseInstance1844F58FD"
}
],
"/aws-cdk-rds-cluster-rotation/Database/Instance2": [
{
"type": "aws:cdk:logicalId",
"data": "DatabaseInstance2AA380DEE",
"trace": [
"!!DESTRUCTIVE_CHANGES: MAY_REPLACE"
]
"data": "DatabaseInstance2AA380DEE"
}
],
"/aws-cdk-rds-cluster-rotation/Database/RotationSingleUser/SecurityGroup/Resource": [
Expand Down Expand Up @@ -321,28 +312,19 @@
"/aws-cdk-rds-cluster-rotation/CustomRotationOptions/Resource": [
{
"type": "aws:cdk:logicalId",
"data": "CustomRotationOptions7CA9E132",
"trace": [
"!!DESTRUCTIVE_CHANGES: MAY_REPLACE"
]
"data": "CustomRotationOptions7CA9E132"
}
],
"/aws-cdk-rds-cluster-rotation/CustomRotationOptions/Instance1": [
{
"type": "aws:cdk:logicalId",
"data": "CustomRotationOptionsInstance1D693E87C",
"trace": [
"!!DESTRUCTIVE_CHANGES: MAY_REPLACE"
]
"data": "CustomRotationOptionsInstance1D693E87C"
}
],
"/aws-cdk-rds-cluster-rotation/CustomRotationOptions/Instance2": [
{
"type": "aws:cdk:logicalId",
"data": "CustomRotationOptionsInstance2A21FADD8",
"trace": [
"!!DESTRUCTIVE_CHANGES: MAY_REPLACE"
]
"data": "CustomRotationOptionsInstance2A21FADD8"
}
],
"/aws-cdk-rds-cluster-rotation/CustomRotationOptions/RotationSingleUser/SARMapping": [
Expand Down
Loading