Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eks): Changing EKS helm chart handler runtime from Python 3.7 to 3.8 #26385

Closed
wants to merge 1 commit into from

Conversation

youngjeong46
Copy link

Currently the Helm Chart handler for aws-eks package is using Python 3.7. We have seen, as from the issue listed below, that there are issues with certificates that won't be accepted when running with Python 3.7 (i.e. JupyterHub).

This PR replaces the Lambda Handler for Helm Chart runtime from Python 3.7 to 3.8.
Closes #25747.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added bug This issue is a bug. effort/medium Medium work item – several days of effort p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Jul 17, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team July 17, 2023 02:21
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 43c0486
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@youngjeong46 thanks for the PR! Are you able to continue working on this? There are quite a few integration tests that are failing because they need to be tested with python 3.8.

I don't think I can do them for you because you're on your own main branch so if you don't have the time I can spin up my own PR and update the runtime.

@youngjeong46
Copy link
Author

@youngjeong46 thanks for the PR! Are you able to continue working on this? There are quite a few integration tests that are failing because they need to be tested with python 3.8.

I don't think I can do them for you because you're on your own main branch so if you don't have the time I can spin up my own PR and update the runtime.

@kaizencc Can you work on the PR? I keep running out of heap space on all of my environments building integration tests.

@kaizencc
Copy link
Contributor

kaizencc commented Aug 2, 2023

@youngjeong46 I can't do them on this PR, so I'd have to open a new one.

If you're running out of heap space, you can try export NODE_OPTIONS="--max-old-space-size=8192" && npx lerna run build --scope=aws-cdk-lib

@rix0rrr
Copy link
Contributor

rix0rrr commented Aug 4, 2023

Or create a branch in your fork, and change the PR to be based off the branch.

@aws-cdk-automation
Copy link
Collaborator

This PR has been in the BUILD FAILING state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Aug 16, 2023
@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Fixes must contain a change to a test file.
❌ Fixes must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/medium Medium work item – several days of effort p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-eks: addHelmChart not accepting SSL certificate from public JupyterHub helm chart
4 participants