-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(eks): Changing EKS helm chart handler runtime from Python 3.7 to 3.8 #26385
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@youngjeong46 thanks for the PR! Are you able to continue working on this? There are quite a few integration tests that are failing because they need to be tested with python 3.8.
I don't think I can do them for you because you're on your own main branch so if you don't have the time I can spin up my own PR and update the runtime.
@kaizencc Can you work on the PR? I keep running out of heap space on all of my environments building integration tests. |
@youngjeong46 I can't do them on this PR, so I'd have to open a new one. If you're running out of heap space, you can try |
Or create a branch in your fork, and change the PR to be based off the branch. |
This PR has been in the BUILD FAILING state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
Currently the Helm Chart handler for aws-eks package is using Python 3.7. We have seen, as from the issue listed below, that there are issues with certificates that won't be accepted when running with Python 3.7 (i.e. JupyterHub).
This PR replaces the Lambda Handler for Helm Chart runtime from Python 3.7 to 3.8.
Closes #25747.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license