Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(integ-tests-alpha): integ tests link is incorrect #26402

Merged
merged 2 commits into from
Jul 18, 2023
Merged

chore(integ-tests-alpha): integ tests link is incorrect #26402

merged 2 commits into from
Jul 18, 2023

Conversation

go-to-k
Copy link
Contributor

@go-to-k go-to-k commented Jul 18, 2023

This PR corrects integ tests link in an integ-runner doc and an error message.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added valued-contributor [Pilot] contributed between 6-12 PRs to the CDK p2 labels Jul 18, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team July 18, 2023 11:35
aws-cdk-automation
aws-cdk-automation previously requested changes Jul 18, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@go-to-k go-to-k marked this pull request as draft July 18, 2023 11:40
@go-to-k
Copy link
Contributor Author

go-to-k commented Jul 18, 2023

Exemption Request
Because this PR only changes a link, I think that unit testing is sufficient.

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Jul 18, 2023
@go-to-k go-to-k marked this pull request as ready for review July 18, 2023 12:01
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 18, 2023
@mrgrain mrgrain added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Jul 18, 2023
@mrgrain mrgrain changed the title fix(integ-tests-alpha): integ tests link is incorrect chore(integ-tests-alpha): integ tests link is incorrect Jul 18, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review July 18, 2023 12:35

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Jul 18, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 18, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: faf6ff3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 576a851 into aws:main Jul 18, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 18, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

bmoffatt pushed a commit to bmoffatt/aws-cdk that referenced this pull request Jul 29, 2023
@go-to-k @bmoffatt
chore(integ-tests-alpha): integ tests link is incorrect (aws#26402)
954df5d 
This PR corrects integ tests link in an integ-runner doc and an error message.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions github-actions bot mentioned this pull request Aug 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrgrain mrgrain mrgrain approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. valued-contributor [Pilot] contributed between 6-12 PRs to the CDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@go-to-k @aws-cdk-automation @mrgrain