Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lambda): Update Python Lambda Adot Lambda layer versions #26411

Merged
merged 5 commits into from
Jul 19, 2023

Conversation

randyridgley
Copy link
Contributor

@randyridgley randyridgley commented Jul 18, 2023

This PR adds the additional versions of the Python Adot for Lambda Layers. I added the versions from 1.13 -1.18 and marked 1.18 as LATEST. The integration and unit tests updated for versions 1.18. Not sure if this fix is maintainable in the long term, if there are ideas on ways to dynamically add additional versions in the future.

Exemption Request: This is an update to a class supporting the Lambda Layer versions for Python Adot. New functionality from an integration standpoint does not exist.

Closes #26168.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added p2 repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK labels Jul 18, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team July 18, 2023 19:12
@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort labels Jul 18, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@randyridgley randyridgley changed the title fix(aws-lambda) Update Python Lambda Adot Lambda layer versions fix(aws-lambda): Update Python Lambda Adot Lambda layer versions Jul 18, 2023
@randyridgley randyridgley changed the title fix(aws-lambda): Update Python Lambda Adot Lambda layer versions fix(lambda): Update Python Lambda Adot Lambda layer versions Jul 18, 2023
@randyridgley
Copy link
Contributor Author

Exemption Request: This is an update to a class supporting the Lambda Layer versions for Python Adot. New functionality from an integration standpoint does not exist.

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Jul 18, 2023
@mrgrain
Copy link
Contributor

mrgrain commented Jul 18, 2023

@randyridgley Yeah would be good to have a source for this that updates automatically. Where are you getting these currently from? Maybe you could reach out to the internal team?

@randyridgley
Copy link
Contributor Author

randyridgley commented Jul 18, 2023

@mrgrain It comes from https://github.com/open-telemetry/opentelemetry-python/releases I'll try and find someone that can help. Do you know if we have another example in the aws-cdk codebase that acts similarly?

@randyridgley
Copy link
Contributor Author

randyridgley commented Jul 18, 2023

It seems ADOT versions are create like LambdaInsights versions in a static fashion in fact-tables.ts, but when new versions are generated the static variables need to be manually added to the appropriate places. For these types of Lambda layers we know the new versions when they are statically created by a github action but not available based on the rigid use of the classes.

fact-tables.ts

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: debbdd2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 19, 2023
@mrgrain mrgrain added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Jul 19, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review July 19, 2023 21:52

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 19, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 19, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 47f15a6 into aws:main Jul 19, 2023
bmoffatt pushed a commit to bmoffatt/aws-cdk that referenced this pull request Jul 29, 2023
This PR adds the additional versions of the Python Adot for Lambda Layers. I added the versions from 1.13 -1.18 and marked  1.18 as LATEST. The integration and unit tests updated for versions 1.18. Not sure if this fix is maintainable in the long term, if there are ideas on ways to dynamically add additional versions in the future.

Exemption Request: This is an update to a class supporting the Lambda Layer versions for Python Adot. New functionality from an integration standpoint does not exist.

Closes aws#26168.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. effort/small Small work item – less than a day of effort p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-cdk-lib.aws_lambda: AdotLambdaLayerPythonSdkVersion incorrect latest version
3 participants