Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(contributing): document how to get around node out of memory error #26465

Merged
merged 3 commits into from
Jul 21, 2023
Merged

docs(contributing): document how to get around node out of memory error #26465

merged 3 commits into from
Jul 21, 2023

Conversation

bun913
Copy link
Contributor

@bun913 bun913 commented Jul 21, 2023

Closes #26415

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added effort/small Small work item – less than a day of effort p1 labels Jul 21, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team July 21, 2023 13:12
@bun913 bun913 changed the title docs(contributing.md) add notification for build error docs(contributing.md): add notification for build error Jul 21, 2023
aws-cdk-automation
aws-cdk-automation previously requested changes Jul 21, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@github-actions github-actions bot added the valued-contributor [Pilot] contributed between 6-12 PRs to the CDK label Jul 21, 2023
@bun913 bun913 changed the title docs(contributing.md): add notification for build error docs: add notification for build error Jul 21, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review July 21, 2023 13:21

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

mrgrain
mrgrain previously approved these changes Jul 21, 2023
View reviewed changes
@mergify mergify bot dismissed mrgrain’s stale review July 21, 2023 13:36

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 21, 2023
@mrgrain mrgrain changed the title docs: add notification for build error docs(contributing): document how to get around node out of memory error Jul 21, 2023
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 21, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 21, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 46b8e6c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 87ec525 into aws:main Jul 21, 2023
5 checks passed
@mergify
Copy link
Contributor

mergify bot commented Jul 21, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@bun913 bun913 deleted the docs/supplement-for-build-error branch July 21, 2023 22:01
bmoffatt pushed a commit to bmoffatt/aws-cdk that referenced this pull request Jul 29, 2023
@bun913 @bmoffatt
docs(contributing): document how to get around node out of memory err…
e0ae517 
…or (aws#26465)

Closes aws#26415 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions github-actions bot mentioned this pull request Aug 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrgrain mrgrain mrgrain approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
effort/small Small work item – less than a day of effort p1 valued-contributor [Pilot] contributed between 6-12 PRs to the CDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(build error): (npx lerna run build --scope=aws-cdk-lib is failed with heap out of memory)
3 participants
@bun913 @aws-cdk-automation @mrgrain