-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update aws service spec in a separate job #26531
Conversation
5f9ea23
to
89c1371
Compare
run: |- | ||
# Upgrade dependencies at repository root | ||
ncu --upgrade --filter=typescript --target=patch | ||
ncu --upgrade --reject=@types/node,@types/prettier,constructs,typescript,lerna --target=minor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Special case notice was:
We special-case lerna because we have a patch on it that stops applying if Lerna upgrades. Remove this once lerna/lerna#2874 releases.
The linked PR has now been published and we have already upgraded lerna manually beyond it.
The patch is long gone as well.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Currently this is just part of the
Yarn upgrade
workflow.We want a separate workflow so the updates are visible in the CHANGELOG.
This should also reduce potential failures in the
Yarn upgrade
workflow and vice-versa, so they don't block each other.Tested o fork: https://github.com/mrgrain/aws-cdk/actions/runs/5680204361
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license