Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update aws service spec in a separate job #26531

Merged
merged 2 commits into from
Jul 27, 2023

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Jul 27, 2023

Currently this is just part of the Yarn upgrade workflow.
We want a separate workflow so the updates are visible in the CHANGELOG.

This should also reduce potential failures in the Yarn upgrade workflow and vice-versa, so they don't block each other.

Tested o fork: https://github.com/mrgrain/aws-cdk/actions/runs/5680204361


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team July 27, 2023 10:35
@github-actions github-actions bot added the p2 label Jul 27, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jul 27, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 27, 2023
@mrgrain mrgrain force-pushed the mrgrain/chore/spec-upgrade-workflow branch from 5f9ea23 to 89c1371 Compare July 27, 2023 11:57
run: |-
# Upgrade dependencies at repository root
ncu --upgrade --filter=typescript --target=patch
ncu --upgrade --reject=@types/node,@types/prettier,constructs,typescript,lerna --target=minor
Copy link
Contributor Author

@mrgrain mrgrain Jul 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Special case notice was:

We special-case lerna because we have a patch on it that stops applying if Lerna upgrades. Remove this once lerna/lerna#2874 releases.

The linked PR has now been published and we have already upgraded lerna manually beyond it.
The patch is long gone as well.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 27, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 27, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 8c86498
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jul 27, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit cfb8c62 into main Jul 27, 2023
7 checks passed
@mergify mergify bot deleted the mrgrain/chore/spec-upgrade-workflow branch July 27, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants