chore(cdk-lib): cloud-assembly-schema tests are flaky, becaue they are not free of side-effects #26568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
aws-cdk-automation
added
the
pr/needs-maintainer-review
iliapolo
approved these changes
Jul 30, 2023
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
aws-cdk-automation
removed
the
pr/needs-maintainer-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The attempted fix in #26551 did not work.
This is another attempt with a different approach.
Based on the fact that the failure occurs in
manifest.ts, there appear to be circumstances for this file to be load in a context that is not fully initialized. Thus theCannot find name 'require'error.However runtime code like
requireis not needed to generate the schemas.In fact the
manifest.tsfile isn't needed at all for this.This change ensures that only the required files are loaded when generating each schema.
Hopefully this will bypass the erroneous code.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license